Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: ios/net/cookies/cookie_store_ios_unittest.mm

Issue 2383393002: Remove stl_util's deletion functions from net/cookies/ and net/extras/. (Closed)
Patch Set: removing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/net/quota_policy_cookie_store_unittest.cc ('k') | net/cookies/cookie_monster.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/net/cookies/cookie_store_ios_unittest.mm
diff --git a/ios/net/cookies/cookie_store_ios_unittest.mm b/ios/net/cookies/cookie_store_ios_unittest.mm
index bb516a58ccaf1d651269a3f12a149daee67059ec..87c7bd4e9b0c00f359566630b2112e7c5ca9541b 100644
--- a/ios/net/cookies/cookie_store_ios_unittest.mm
+++ b/ios/net/cookies/cookie_store_ios_unittest.mm
@@ -249,13 +249,13 @@ class TestPersistentCookieStore
// Runs the completion callback with a "a=b" cookie.
void RunLoadedCallback() {
- std::vector<net::CanonicalCookie*> cookies;
+ std::vector<std::unique_ptr<net::CanonicalCookie>> cookies;
net::CookieOptions options;
options.set_include_httponly();
std::unique_ptr<net::CanonicalCookie> cookie(net::CanonicalCookie::Create(
kTestCookieURL, "a=b", base::Time::Now(), options));
- cookies.push_back(cookie.release());
+ cookies.push_back(std::move(cookie));
// Some canonical cookies cannot be converted into System cookies, for
// example if value is not valid utf8. Such cookies are ignored.
@@ -269,8 +269,8 @@ class TestPersistentCookieStore
false, // httponly
net::CookieSameSite::DEFAULT_MODE, false,
net::COOKIE_PRIORITY_DEFAULT));
- cookies.push_back(bad_canonical_cookie.release());
- loaded_callback_.Run(cookies);
+ cookies.push_back(std::move(bad_canonical_cookie));
+ loaded_callback_.Run(std::move(cookies));
}
bool flushed() { return flushed_; }
« no previous file with comments | « content/browser/net/quota_policy_cookie_store_unittest.cc ('k') | net/cookies/cookie_monster.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698