Views: Add two disabled tests for invoking the CC unmask prompt dialog.

chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc

Index: chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
diff --git a/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc b/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
index deb01c867569f3050df80917e8a555dadf902b28..85a6ac28fa6bce4ff316e0e1f21f53820d886393 100644
--- a/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
+++ b/chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc
@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/guid.h"
 #include "base/location.h"
 #include "base/macros.h"
@@ -15,6 +16,7 @@
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/use_interactive_test_case.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/card_unmask_delegate.h"
 #include "components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h"
@@ -95,6 +97,18 @@ class CardUnmaskPromptViewBrowserTest : public InProcessBrowserTest {
     delegate_.reset(new TestCardUnmaskDelegate());
   }
 
+  void ShowUI(bool expired) {
+    CardUnmaskPromptView* dialog =
+        CreateCardUnmaskPromptView(controller(), contents());
+    CreditCard cc;

[tapted, 2016/10/16 23:48:01]

nit:

CreditCard cc = expired
    ? test::GetMaskedServerCard()
    : test::GetMaskedServerCardAmex();

[Patti Lor, 2016/10/17 23:26:09]

Done.

+    if (expired)
+      cc = test::GetMaskedServerCard();
+    else
+      cc = test::GetMaskedServerCardAmex();
+    controller()->ShowPrompt(dialog, cc, AutofillClient::UNMASK_FOR_AUTOFILL,
+                             delegate()->GetWeakPtr());
+  }
+
   void FreeDelegate() { delegate_.reset(); }
 
   content::WebContents* contents() { return contents_; }
@@ -113,11 +127,19 @@ class CardUnmaskPromptViewBrowserTest : public InProcessBrowserTest {
   DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptViewBrowserTest);
 };
 
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,

[tapted, 2016/10/16 23:48:01]

nit: these need a comment

[Patti Lor, 2016/10/17 23:26:09]

Done.

+                       DISABLED_InvokeExpired) {
+  ShowUI(true);
+  RunTestInteractively();
+}
+
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DISABLED_InvokeValid) {
+  ShowUI(false);
+  RunTestInteractively();
+}
+
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DisplayUI) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
 }
 
 // TODO(bondd): bring up on Mac.

[tapted, 2016/10/16 23:48:01]

hrmh - we need to do something about this. I don't think bondd is around any
longer and there's no crbug link for the TODO. Probably this will get
lost/forgotten about, but at the very least we should try to bring up this test
when switching to mac_views_browser - can you investigate whether there's an
investigation on the initial code review via git blame?

Maybe this is already working with MacViewsWebUIDialogs enabled.

If there's no appropriate existing bug, we might need a "Phase 4" bug (like
phase3 in http://crbug.com/603386). 

[Patti Lor, 2016/10/17 23:26:08]

I don't think there's any ongoing work - the most related bug I could find is
https://crbug.com/448572 which has been marked fixed already. The TODO was
originally added by estade@ (not bondd@, see
https://codereview.chromium.org/1020013003), so maybe they would be a good
person to ask if we'd like to double check there isn't someone working on it. It
seems to work already for MacViews though, just not Cocoa (there needs to be a
Cocoa version of CardUnmaskPromptViewTesterViews). Are we interested in fixing
for Cocoa as well? Or just refactor the test out so it's defined on MacViews?

@@ -126,10 +148,7 @@ IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DisplayUI) {
 // message is showing.
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,
                        EarlyCloseAfterSuccess) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
   controller()->OnUnmaskResponse(base::ASCIIToUTF16("123"),
                                  base::ASCIIToUTF16("10"),
                                  base::ASCIIToUTF16("19"), false);
@@ -151,10 +170,7 @@ IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,
 // https://crbug.com/484376
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,
                        CloseTabWhileDialogShowing) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
   // Simulate AutofillManager (the delegate in production code) being destroyed
   // before CardUnmaskPromptViewBridge::OnConstrainedWindowClosed() is called.
   FreeDelegate();