Views: Add two disabled tests for invoking the CC unmask prompt dialog.

chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/guid.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/autofill/card_unmask_prompt_view_tester.h"
 #include "chrome/browser/ui/autofill/create_card_unmask_prompt_view.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
+#include "chrome/test/base/use_interactive_test_case.h"
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/card_unmask_delegate.h"
 #include "components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_utils.h"
 
 namespace autofill {
 
@@ skipping 60 matching lines @@
 
   ~CardUnmaskPromptViewBrowserTest() override {}
 
   void SetUpOnMainThread() override {
     runner_ = new content::MessageLoopRunner;
     contents_ = browser()->tab_strip_model()->GetActiveWebContents();
     controller_.reset(new TestCardUnmaskPromptController(contents_, runner_));
     delegate_.reset(new TestCardUnmaskDelegate());
   }
 
+  void ShowUI(bool expired) {
+    CardUnmaskPromptView* dialog =
+        CreateCardUnmaskPromptView(controller(), contents());
+    CreditCard cc;

[tapted, 2016/10/16 23:48:01]

nit:

CreditCard cc = expired
    ? test::GetMaskedServerCard()
    : test::GetMaskedServerCardAmex();

[Patti Lor, 2016/10/17 23:26:09]

Done.

+    if (expired)
+      cc = test::GetMaskedServerCard();
+    else
+      cc = test::GetMaskedServerCardAmex();
+    controller()->ShowPrompt(dialog, cc, AutofillClient::UNMASK_FOR_AUTOFILL,
+                             delegate()->GetWeakPtr());
+  }
+
   void FreeDelegate() { delegate_.reset(); }
 
   content::WebContents* contents() { return contents_; }
   TestCardUnmaskPromptController* controller() { return controller_.get(); }
   TestCardUnmaskDelegate* delegate() { return delegate_.get(); }
 
  protected:
   // This member must outlive the controller.
   scoped_refptr<content::MessageLoopRunner> runner_;
 
  private:
   content::WebContents* contents_;
   std::unique_ptr<TestCardUnmaskPromptController> controller_;
   std::unique_ptr<TestCardUnmaskDelegate> delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(CardUnmaskPromptViewBrowserTest);
 };
 
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,

[tapted, 2016/10/16 23:48:01]

nit: these need a comment

[Patti Lor, 2016/10/17 23:26:09]

Done.

+                       DISABLED_InvokeExpired) {
+  ShowUI(true);
+  RunTestInteractively();
+}
+
+IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DISABLED_InvokeValid) {
+  ShowUI(false);
+  RunTestInteractively();
+}
+
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest, DisplayUI) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
 }
 
 // TODO(bondd): bring up on Mac.

[tapted, 2016/10/16 23:48:01]

hrmh - we need to do something about this. I don't think bondd is around any
longer and there's no crbug link for the TODO. Probably this will get
lost/forgotten about, but at the very least we should try to bring up this test
when switching to mac_views_browser - can you investigate whether there's an
investigation on the initial code review via git blame?

Maybe this is already working with MacViewsWebUIDialogs enabled.

If there's no appropriate existing bug, we might need a "Phase 4" bug (like
phase3 in http://crbug.com/603386). 

[Patti Lor, 2016/10/17 23:26:08]

I don't think there's any ongoing work - the most related bug I could find is
https://crbug.com/448572 which has been marked fixed already. The TODO was
originally added by estade@ (not bondd@, see
https://codereview.chromium.org/1020013003), so maybe they would be a good
person to ask if we'd like to double check there isn't someone working on it. It
seems to work already for MacViews though, just not Cocoa (there needs to be a
Cocoa version of CardUnmaskPromptViewTesterViews). Are we interested in fixing
for Cocoa as well? Or just refactor the test out so it's defined on MacViews?

 #if !defined(OS_MACOSX)
 // Makes sure the user can close the dialog while the verification success
 // message is showing.
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,
                        EarlyCloseAfterSuccess) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
   controller()->OnUnmaskResponse(base::ASCIIToUTF16("123"),
                                  base::ASCIIToUTF16("10"),
                                  base::ASCIIToUTF16("19"), false);
   EXPECT_EQ(base::ASCIIToUTF16("123"), delegate()->response().cvc);
   controller()->OnVerificationResult(AutofillClient::SUCCESS);
 
   // Simulate the user clicking [x] before the "Success!" message disappears.
   CardUnmaskPromptViewTester::For(controller()->view())->Close();
   // Wait a little while; there should be no crash.
   base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
       FROM_HERE, base::Bind(&content::MessageLoopRunner::Quit,
                             base::Unretained(runner_.get())),
       2 * controller()->GetSuccessMessageDuration());
   runner_->Run();
 }
 #endif
 
 // Makes sure the tab can be closed while the dialog is showing.
 // https://crbug.com/484376
 IN_PROC_BROWSER_TEST_F(CardUnmaskPromptViewBrowserTest,
                        CloseTabWhileDialogShowing) {
-  controller()->ShowPrompt(CreateCardUnmaskPromptView(controller(), contents()),
-                           test::GetMaskedServerCard(),
-                           AutofillClient::UNMASK_FOR_AUTOFILL,
-                           delegate()->GetWeakPtr());
+  ShowUI(true);
   // Simulate AutofillManager (the delegate in production code) being destroyed
   // before CardUnmaskPromptViewBridge::OnConstrainedWindowClosed() is called.
   FreeDelegate();
   browser()->tab_strip_model()->GetActiveWebContents()->Close();
 
   content::RunAllPendingInMessageLoop();
 }
 
 }  // namespace
 
 }  // namespace autofill