Add a regression test for the CardUnmaskPrompt.

Add a regression test for the CardUnmaskPrompt.

BUG=none

Committed: https://crrev.com/b908f6894ec52c26b2c78ecbe3f2574e0c38d435
Cr-Commit-Position: refs/heads/master@{#321634}

[Evan Stade, 2015-03-19 22:54:35]

estade@chromium.org changed reviewers:
+ groby@chromium.org

[Evan Stade, 2015-03-19 22:54:36]

most changes are reorganizing CardUnmaskPromptViews into header and impl file
-_-

[groby-ooo-7-16, 2015-03-19 23:47:56]

LGTM unless there's a reasonable way to get rid of the ad-hoc time constant in
the test.

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/card_unmask_prompt_controller.h (right):

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/card_unmask_prompt_controller.h:9: #include
"base/time/time.h"
just forward declare TimeDelta?

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc (right):

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc:127: // Wait a
little while; there should be no crash.
I suppose there's no way we can do without a fuzzy guess here? (I.e. there's no
hook for "done" where we can post the Quit from)

[Evan Stade, 2015-03-20 00:22:42]

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/card_unmask_prompt_controller.h (right):

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/card_unmask_prompt_controller.h:9: #include
"base/time/time.h"
On 2015/03/19 23:47:56, groby wrote:
> just forward declare TimeDelta?

mildly surprised that worked. done

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
File chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc (right):

https://codereview.chromium.org/1020013003/diff/20001/chrome/browser/ui/autof...
chrome/browser/ui/autofill/card_unmask_prompt_view_browsertest.cc:127: // Wait a
little while; there should be no crash.
On 2015/03/19 23:47:56, groby wrote:
> I suppose there's no way we can do without a fuzzy guess here? (I.e. there's
no
> hook for "done" where we can post the Quit from)

The nature of the crash was that a stale closure was being run some amount of
time after the dialog was closed. The solution is to cancel that closure. So no,
there's no function to hook into.

[Evan Stade, 2015-03-20 00:22:47]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-03-20 00:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1020013003/#ps40001
(title: "fwd declare")

[commit-bot: I haz the power, 2015-03-20 00:23:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020013003/40001

[commit-bot: I haz the power, 2015-03-20 00:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 00:27:31]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Evan Stade, 2015-03-20 02:44:17]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-03-20 02:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1020013003/#ps80001
(title: "git cl format weirdness with indentation")

[commit-bot: I haz the power, 2015-03-20 02:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020013003/80001

[commit-bot: I haz the power, 2015-03-20 03:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-20 03:50:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-03-20 19:19:38]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-03-20 19:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org
Link to the patchset: https://codereview.chromium.org/1020013003/#ps100001
(title: "EXPECT")

[commit-bot: I haz the power, 2015-03-20 19:20:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1020013003/100001

[commit-bot: I haz the power, 2015-03-20 21:02:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-20 21:03:30]

Patchset 6 (id:??) landed as
https://crrev.com/b908f6894ec52c26b2c78ecbe3f2574e0c38d435
Cr-Commit-Position: refs/heads/master@{#321634}