Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 23819003: Handlify JSObject::SetAccessor method. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::SetAccessor method. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -88 lines) Patch
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/handles.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.h View 3 chunks +10 lines, -13 lines 0 comments Download
M src/objects.cc View 6 chunks +54 lines, -66 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-08-30 13:20:29 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-08-30 13:55:49 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-08-30 14:08:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698