src/api.cc - Issue 23819003: Handlify JSObject::SetAccessor method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 23819003: Handlify JSObject::SetAccessor method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 643a5b4100082a31b50eb7de472ba9fe256574c9..4e78041788ac159ef916cb0bfd71e4bdaeb29687 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3600,7 +3600,8 @@ static inline bool ObjectSetAccessor(Object* obj,

name, getter, setter, data, settings, attributes, signature);

if (info.is_null()) return false;

bool fast = Utils::OpenHandle(obj)->HasFastProperties();

- i::Handle<i::Object> result = i::SetAccessor(Utils::OpenHandle(obj), info);

+ i::Handle<i::Object> result =

+ i::JSObject::SetAccessor(Utils::OpenHandle(obj), info);

if (result.is_null() || result->IsUndefined()) return false;

if (fast) i::JSObject::TransformToFastProperties(Utils::OpenHandle(obj), 0);

return true;

« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »