Issue 2381403002: Allow the external protocol dialog to handle FORM_SUBMIT navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2381403002: Allow the external protocol dialog to handle FORM_SUBMIT navigation (Closed)

Created:
4 years, 2 months ago by Yusuke Sato

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow the external protocol dialog to handle FORM_SUBMIT navigation It turns out that checking only PAGE_TRANSITION_LINK misses the user's form submission because content/renderer/render_frame_impl.cc changes the core transition type from LINK to FORM_SUBMIT on form submission. BUG=b/31747586 TEST=try Review-Url: https://codereview.chromium.org/2363303003 Cr-Commit-Position: refs/heads/master@{#421123} (cherry picked from commit cda58be581a1489a4aa270b8684d849ffc3cb7a3)

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -5 lines)			Patch
M	chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/arc/arc_navigation_throttle.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/arc/page_transition_util.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/arc/page_transition_util.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
A	chrome/browser/chromeos/arc/page_transition_util_unittest.cc	View	1 chunk	+112 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yusuke Sato

4 years, 2 months ago (2016-09-30 22:31:44 UTC) #1

Description was changed from

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try

Review-Url: https://codereview.chromium.org/2363303003
Cr-Commit-Position: refs/heads/master@{#421123}
(cherry picked from commit cda58be581a1489a4aa270b8684d849ffc3cb7a3)
==========

to

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try

Review-Url: https://codereview.chromium.org/2363303003
Cr-Commit-Position: refs/heads/master@{#421123}
(cherry picked from commit cda58be581a1489a4aa270b8684d849ffc3cb7a3)
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages