Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Unified Diff: chrome/browser/chromeos/arc/page_transition_util.cc

Issue 2381403002: Allow the external protocol dialog to handle FORM_SUBMIT navigation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/page_transition_util.cc
diff --git a/chrome/browser/chromeos/arc/page_transition_util.cc b/chrome/browser/chromeos/arc/page_transition_util.cc
index 9affb1b32155d0aa534d7a726a658b78a2059de2..070e9fdfdcb066e3d76ca834e4fd253e89c3087c 100644
--- a/chrome/browser/chromeos/arc/page_transition_util.cc
+++ b/chrome/browser/chromeos/arc/page_transition_util.cc
@@ -6,13 +6,17 @@
namespace arc {
-bool ShouldIgnoreNavigation(ui::PageTransition page_transition) {
+bool ShouldIgnoreNavigation(ui::PageTransition page_transition,
+ bool allow_form_submit) {
// Mask out server-sided redirects only.
page_transition = ui::PageTransitionFromInt(
page_transition & ~ui::PAGE_TRANSITION_SERVER_REDIRECT);
if (!ui::PageTransitionCoreTypeIs(page_transition,
- ui::PAGE_TRANSITION_LINK)) {
+ ui::PAGE_TRANSITION_LINK) &&
+ !(allow_form_submit &&
+ ui::PageTransitionCoreTypeIs(page_transition,
+ ui::PAGE_TRANSITION_FORM_SUBMIT))) {
// Do not handle the |url| if this event wasn't spawned by the user clicking
// on a link.
return true;
« no previous file with comments | « chrome/browser/chromeos/arc/page_transition_util.h ('k') | chrome/browser/chromeos/arc/page_transition_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698