Allow the external protocol dialog to handle FORM_SUBMIT navigation

Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try

Committed: https://crrev.com/cda58be581a1489a4aa270b8684d849ffc3cb7a3
Cr-Commit-Position: refs/heads/master@{#421123}

[Yusuke Sato, 2016-09-26 16:27:21]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 16:27:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-09-26 16:28:11]

yusukes@chromium.org changed reviewers:
+ kenobi@chromium.org

[Yusuke Sato, 2016-09-26 16:28:12]

Please take a look.

[commit-bot: I haz the power, 2016-09-26 16:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 16:57:05]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-26 17:15:52]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:16:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 17:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 17:42:40]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-26 18:32:50]

Description was changed from

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/29079617
TEST=try
==========

to

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try
==========

[Yusuke Sato, 2016-09-26 19:41:29]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 19:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 20:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:06:50]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-26 23:04:57]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 23:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2016-09-26 23:06:03]

Uploaded PS#4 following your suggestion in the chat. PTAL.

[commit-bot: I haz the power, 2016-09-26 23:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:53:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Kwa, 2016-09-27 05:04:58]

On suggestion/nit but other than that, LGTM.  Thanks!

https://codereview.chromium.org/2363303003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/page_transition_util.cc (right):

https://codereview.chromium.org/2363303003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/page_transition_util.cc:19:
ui::PAGE_TRANSITION_FORM_SUBMIT))) {
Personally I think I'd find

!(allow_form_submit && ui::PageTransitionCoreTypeIs(...)) to be slightly more
readable.  But that's just a suggestion.

[Yusuke Sato, 2016-09-27 05:29:45]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 05:30:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 05:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 05:59:37]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-27 06:03:14]

thanks!

https://codereview.chromium.org/2363303003/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/page_transition_util.cc (right):

https://codereview.chromium.org/2363303003/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/page_transition_util.cc:19:
ui::PAGE_TRANSITION_FORM_SUBMIT))) {
On 2016/09/27 05:04:58, Ben Kwa wrote:
> Personally I think I'd find
> 
> !(allow_form_submit && ui::PageTransitionCoreTypeIs(...)) to be slightly more
> readable.  But that's just a suggestion.

Done.

[Yusuke Sato, 2016-09-27 06:03:18]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-09-27 06:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from kenobi@chromium.org
Link to the patchset: https://codereview.chromium.org/2363303003/#ps80001
(title: "address comment")

[commit-bot: I haz the power, 2016-09-27 06:03:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 06:09:07]

Description was changed from

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try
==========

to

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try
==========

[commit-bot: I haz the power, 2016-09-27 06:09:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-27 06:12:29]

Description was changed from

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try
==========

to

==========
Allow the external protocol dialog to handle FORM_SUBMIT navigation

It turns out that checking only PAGE_TRANSITION_LINK misses the
user's form submission because content/renderer/render_frame_impl.cc
changes the core transition type from LINK to FORM_SUBMIT on
form submission.

BUG=b/31747586
TEST=try

Committed: https://crrev.com/cda58be581a1489a4aa270b8684d849ffc3cb7a3
Cr-Commit-Position: refs/heads/master@{#421123}
==========

[commit-bot: I haz the power, 2016-09-27 06:12:30]

Patchset 5 (id:??) landed as
https://crrev.com/cda58be581a1489a4aa270b8684d849ffc3cb7a3
Cr-Commit-Position: refs/heads/master@{#421123}