Issue 23814008: Revert 220417 "[temporary M30 fix] Disable dragging tabs with we..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23814008: Revert 220417 "[temporary M30 fix] Disable dragging tabs with we..." (Closed)

Created:
7 years, 3 months ago by Mike Wittman

Modified:
7 years, 3 months ago

Reviewers:
Mike Wittman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 220417 "[temporary M30 fix] Disable dragging tabs with we..." Reverting per the original change description. > [temporary M30 fix] Disable dragging tabs with web contents modal dialogs displayed > > The full fix for the crashes in the associated bugs in trunk is too > risky to merge into M30. After discussions among kareng and sky, the > best approach was to disable dragging of tabs while a web contents modal > dialog is displayed, to prevent the crashes. This only affects Chrome > OS and will be reverted after testing in Canary and merging to the > branch. > > BUG=275274, 274856 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/23698003 TBR=wittman@chromium.org BUG=281831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221834

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -31 lines)			Patch
M	trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View	3 chunks	+0 lines, -11 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/tabs/tab_strip_controller.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r221834.

Expand Messages | Collapse Messages