Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc

Issue 23814008: Revert 220417 "[temporary M30 fix] Disable dragging tabs with we..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc
===================================================================
--- trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc (revision 221832)
+++ trunk/src/chrome/browser/ui/views/tabs/tab_strip.cc (working copy)
@@ -1127,16 +1127,6 @@
gfx::Screen::GetScreenFor(widget->GetNativeView())->GetNumDisplays() == 1)
detach_behavior = TabDragController::NOT_DETACHABLE;
-#if defined(OS_CHROMEOS)
- // TODO(wittman): This is a temporary workaround to avoid crbug.com/275274 and
- // crbug.com/274856 in M30 and should be reverted after merge, as we have a
- // solution to these bugs in trunk.
- //
- // Don't allow detaching if the tab has a WebContentsModalDialogView opened.
- if (controller()->IsTabShowingWebViewModalDialog(GetModelIndexOfTab(tab)))
- detach_behavior = TabDragController::NOT_DETACHABLE;
-#endif
-
#if defined(OS_WIN)
// It doesn't make sense to drag tabs out on Win8's single window Metro mode.
if (win8::IsSingleWindowMetroMode())

Powered by Google App Engine
This is Rietveld 408576698