Issue 23698003: [temporary M30 fix] Disable dragging tabs with web contents modal dialogs displayed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23698003: [temporary M30 fix] Disable dragging tabs with web contents modal dialogs displayed (Closed)

Created:
7 years, 3 months ago by Mike Wittman

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, pkotwicz, James Cook

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[temporary M30 fix] Disable dragging tabs with web contents modal dialogs displayed The full fix for the crashes in the associated bugs in trunk is too risky to merge into M30. After discussions among kareng and sky, the best approach was to disable dragging of tabs while a web contents modal dialog is displayed, to prevent the crashes. This only affects Chrome OS and will be reverted after testing in Canary and merging to the branch. BUG=275274, 274856 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220417

Patch Set 1 #

Patch Set 2 : Fix comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip_controller.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Wittman

Hi Scott, please take a look. We'd like to get this in tonight's Canary if ...

7 years, 3 months ago (2013-08-29 20:39:30 UTC) #1

Mike Wittman

7 years, 3 months ago (2013-08-29 23:03:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r220417 (presubmit successful).

Expand Messages | Collapse Messages