mash: Fix shelf window property use in Chrome.

mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,

Committed: https://crrev.com/745fe06919e14e926d3464f64bc2f0d91b00b326
Cr-Commit-Position: refs/heads/master@{#422588}

[msw, 2016-09-30 20:35:58]

Description was changed from

==========
mash: Fix shelf window property use in Chrome.

BUG=634150
==========

to

==========
mash: Fix shelf window property use in Chrome.

TODO: use ash/mus/property_util.h (via ash/public/cpp)?
TODO: Automatically propagate some props with an observer?


BUG=634150
==========

[msw, 2016-09-30 22:31:55]

Description was changed from

==========
mash: Fix shelf window property use in Chrome.

TODO: use ash/mus/property_util.h (via ash/public/cpp)?
TODO: Automatically propagate some props with an observer?


BUG=634150
==========

to

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org
==========

[msw, 2016-09-30 22:31:55]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-09-30 22:33:43]

Hey James, please take a look; thanks!

[msw, 2016-09-30 22:33:49]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 22:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 23:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 23:33:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-09-30 23:58:08]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 23:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 00:14:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:14:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-01 00:16:21]

Wow, this looks like it was tricky to figure out.

https://codereview.chromium.org/2381183002/diff/60001/ash/mus/window_manager.cc
File ash/mus/window_manager.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/ash/mus/window_manager....
ash/mus/window_manager.cc:304: name ==
ui::mojom::WindowManager::kShelfItemType_Property ||
Does this need ShelfID?

https://codereview.chromium.org/2381183002/diff/60001/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/2381183002/diff/60001/ash/wm/window_propertie...
ash/wm/window_properties.h:46: // A property key to store the icon resource id
for a window's shelf item.
Hooray for nice docs on property keys.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:253:
SettingsWindowObserver settings_window_observer_;
Hmm. I see why you did this, but this is mostly a pure-virtual interface class.
Is there anywhere else this could go that has the right lifetime?

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/settings_window_observer.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:8: #include
"ash/common/wm_lookup.h"
I think you have a few unnecessary headers here.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:29: class
AuraWindowSettingsTitleTracker : public aura::WindowTracker {
This and the class below could use a comment about when they are used (classic
ash vs. mash).

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:70: :
aura_window_tracker_(new AuraWindowSettingsTitleTracker),
Only create the one you need based on IsRunningInMash?

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:82: SetTitle(window,
l10n_util::GetStringUTF16(IDS_SETTINGS_TITLE));
This function, and the ones below, need to be in a namespace property_util or
static class PropertyUtil. It's confusing having a bare function called
SetTitle().

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
File chrome/browser/ui/ash/property_util.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:30: ui::Window* ui_window =
aura::GetMusWindow(window);
nit: DCHECK(window)?

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:31: if (ui_window)
I think it would be better to check IsRunningInMash() here, rather than the
existence of a ui_window. Then you could DCHECK(ui_window).

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:37: void SetTitle(aura::Window* window,
const base::string16& value) {
Should these functions take a views::Widget instead of aura::Window? Is it ever
going to be valid to set the title (or random int properties) on a non-widget
window?

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:39: if (ui_window) {
ditto re IsRunningInMash, DCHECKS, etc.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
File chrome/browser/ui/ash/property_util.h (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.h:6: #define
CHROME_BROWSER_UI_ASH_PROPERTY_UTIL_H_
optional: property_util.h is pretty generic. How about something about windows
or widgets?

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/task_manager_view.cc:37: #include
"ash/common/shelf/shelf_item_types.h"    // nogncheck
Aside: Any idea why these are nogncheck? Is there no explicit dep from views ->
ash?

[msw, 2016-10-03 18:01:35]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:09:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[msw, 2016-10-03 18:18:43]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-03 18:24:02]

Patchset #7 (id:120001) has been deleted

[msw, 2016-10-03 18:24:09]

Patchset #6 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-10-03 18:24:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-10-03 18:24:19]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-10-03 18:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:42:55]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[msw, 2016-10-03 18:50:25]

Patchset #5 (id:140001) has been deleted

[msw, 2016-10-03 18:50:36]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 18:51:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-10-03 19:11:37]

Description was changed from

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org
==========

to

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,
==========

[msw, 2016-10-03 19:11:37]

msw@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[msw, 2016-10-03 19:14:24]

Hey Scott, PTAL at ui/aura/window.cc (optionally more).
Hey Tom, PTAL at window_manager.mojom.
Hey James, please take another look.
Thanks!

https://codereview.chromium.org/2381183002/diff/60001/ash/mus/window_manager.cc
File ash/mus/window_manager.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/ash/mus/window_manager....
ash/mus/window_manager.cc:304: name ==
ui::mojom::WindowManager::kShelfItemType_Property ||
On 2016/10/01 00:16:20, James Cook wrote:
> Does this need ShelfID?

Not yet; it will if Chrome needs to actually set windows' ShelfIDs.

https://codereview.chromium.org/2381183002/diff/60001/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/2381183002/diff/60001/ash/wm/window_propertie...
ash/wm/window_properties.h:46: // A property key to store the icon resource id
for a window's shelf item.
On 2016/10/01 00:16:20, James Cook wrote:
> Hooray for nice docs on property keys.

Acknowledged.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.h (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.h:253:
SettingsWindowObserver settings_window_observer_;
On 2016/10/01 00:16:21, James Cook wrote:
> Hmm. I see why you did this, but this is mostly a pure-virtual interface
class.
> Is there anywhere else this could go that has the right lifetime?

Where do you suggest? ChromeLauncherControllerImpl was the previous owner (via
BrowserStatusMonitor); this is just the base class also used in mash.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/settings_window_observer.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:8: #include
"ash/common/wm_lookup.h"
On 2016/10/01 00:16:21, James Cook wrote:
> I think you have a few unnecessary headers here.

Done; let me know if I missed any.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:29: class
AuraWindowSettingsTitleTracker : public aura::WindowTracker {
On 2016/10/01 00:16:21, James Cook wrote:
> This and the class below could use a comment about when they are used (classic
> ash vs. mash).

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:70: :
aura_window_tracker_(new AuraWindowSettingsTitleTracker),
On 2016/10/01 00:16:21, James Cook wrote:
> Only create the one you need based on IsRunningInMash?
> 

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/settings_window_observer.cc:82: SetTitle(window,
l10n_util::GetStringUTF16(IDS_SETTINGS_TITLE));
On 2016/10/01 00:16:21, James Cook wrote:
> This function, and the ones below, need to be in a namespace property_util or
> static class PropertyUtil. It's confusing having a bare function called
> SetTitle().

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
File chrome/browser/ui/ash/property_util.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:30: ui::Window* ui_window =
aura::GetMusWindow(window);
On 2016/10/01 00:16:21, James Cook wrote:
> nit: DCHECK(window)?

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:31: if (ui_window)
On 2016/10/01 00:16:21, James Cook wrote:
> I think it would be better to check IsRunningInMash() here, rather than the
> existence of a ui_window. Then you could DCHECK(ui_window).

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:37: void SetTitle(aura::Window* window,
const base::string16& value) {
On 2016/10/01 00:16:21, James Cook wrote:
> Should these functions take a views::Widget instead of aura::Window? Is it
ever
> going to be valid to set the title (or random int properties) on a non-widget
> window?

I'm following the example of ash/mus/property_util.h

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.cc:39: if (ui_window) {
On 2016/10/01 00:16:21, James Cook wrote:
> ditto re IsRunningInMash, DCHECKS, etc.

Done.

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
File chrome/browser/ui/ash/property_util.h (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/ash/p...
chrome/browser/ui/ash/property_util.h:6: #define
CHROME_BROWSER_UI_ASH_PROPERTY_UTIL_H_
On 2016/10/01 00:16:21, James Cook wrote:
> optional: property_util.h is pretty generic. How about something about windows
> or widgets?

I'm following the example of ash/mus/property_util.h

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/task_manager_view.cc (right):

https://codereview.chromium.org/2381183002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/task_manager_view.cc:37: #include
"ash/common/shelf/shelf_item_types.h"    // nogncheck
On 2016/10/01 00:16:21, James Cook wrote:
> Aside: Any idea why these are nogncheck? Is there no explicit dep from views
->
> ash?

gn check trips over the conditional here; I added a comment.

[commit-bot: I haz the power, 2016-10-03 19:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 19:49:38]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-10-03 20:38:12]

LGTM

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/settings_window_observer.h (right):

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/settings_window_observer.h:24: // Window trackers
used to rename the Settings window in cash and mash.
super nit: I'm trying to standardize on "classic ash" instead of cash. Cash is
too generic.

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/property_util.cc (right):

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/property_util.cc:45: if (chrome::IsRunningInMash()) {
DCHECK(window) above, please

[sky, 2016-10-03 21:50:00]

LGTM

[Tom Sepez, 2016-10-03 21:55:18]

mojom lgtm

[msw, 2016-10-03 22:02:25]

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/settings_window_observer.h (right):

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/settings_window_observer.h:24: // Window trackers
used to rename the Settings window in cash and mash.
On 2016/10/03 20:38:12, James Cook wrote:
> super nit: I'm trying to standardize on "classic ash" instead of cash. Cash is
> too generic.

Done.

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/property_util.cc (right):

https://codereview.chromium.org/2381183002/diff/160001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/property_util.cc:45: if (chrome::IsRunningInMash()) {
On 2016/10/03 20:38:12, James Cook wrote:
> DCHECK(window) above, please

Done.

[msw, 2016-10-03 22:02:37]

The CQ bit was checked by msw@chromium.org

[msw, 2016-10-03 22:02:37]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2381183002/#ps180001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-10-03 22:03:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 23:09:37]

Description was changed from

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,
==========

to

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,
==========

[commit-bot: I haz the power, 2016-10-03 23:09:38]

Committed patchset #6 (id:180001)

[commit-bot: I haz the power, 2016-10-03 23:11:18]

Description was changed from

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,
==========

to

==========
mash: Fix shelf window property use in Chrome.

Support the ShelfID window property in mash.
(ShelfWindowWatcher uses this to find existing items)
Allow WM clients to set ShelfItemType and ShelfIconResourceId.
Define aura property keys in a shared location for chrome and ash.

Notify WmWindowObserver of certain white-listed property changes.
Add WmWindowProperty::INVALID_PROPERTY for key translation checks.

Add property utility functions to c/b/ui/ash for aura/ui windows.
Use SettingsWindowObserver in ChromeLauncherController (cash&mash).
Use separate aura/ui window trackers to watch for name changes.
(Can't use ash::WmWindow in Chrome... depends on ash internals)

Early return from Window::SetTitle if the values match.

TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)?
TODO: Automatically propagate some props with an observer?

BUG=634150
TEST=chrome --mash shows task manager and settings shelf icons.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,

Committed: https://crrev.com/745fe06919e14e926d3464f64bc2f0d91b00b326
Cr-Commit-Position: refs/heads/master@{#422588}
==========

[commit-bot: I haz the power, 2016-10-03 23:11:19]

Patchset 6 (id:??) landed as
https://crrev.com/745fe06919e14e926d3464f64bc2f0d91b00b326
Cr-Commit-Position: refs/heads/master@{#422588}