Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: chrome/browser/ui/ash/launcher/settings_window_observer.h

Issue 2381183002: mash: Fix shelf window property use in Chrome. (Closed)
Patch Set: Address comments, cleanup, and try to fix build issues. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_SETTINGS_WINDOW_OBSERVER_H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_SETTINGS_WINDOW_OBSERVER_H_
7
8 #include "base/macros.h"
9 #include "chrome/browser/ui/settings_window_manager_observer.h"
10 #include "services/ui/public/cpp/window_tracker.h"
11 #include "ui/aura/window_tracker.h"
12
13 // Sets the window title and shelf item properties for settings windows.
14 // Settings windows are not handled by BrowserShortcutLauncherItemController.
15 class SettingsWindowObserver : public chrome::SettingsWindowManagerObserver {
16 public:
17 SettingsWindowObserver();
18 ~SettingsWindowObserver() override;
19
20 // SettingsWindowManagerObserver:
21 void OnNewSettingsWindow(Browser* settings_browser) override;
22
23 private:
24 // Window trackers used to rename the Settings window in cash and mash.
James Cook 2016/10/03 20:38:12 super nit: I'm trying to standardize on "classic a
msw 2016/10/03 22:02:24 Done.
25 std::unique_ptr<aura::WindowTracker> aura_window_tracker_;
26 std::unique_ptr<ui::WindowTracker> ui_window_tracker_;
27
28 DISALLOW_COPY_AND_ASSIGN(SettingsWindowObserver);
29 };
30
31 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_SETTINGS_WINDOW_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698