Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: ash/aura/wm_window_aura.cc

Issue 2381183002: mash: Fix shelf window property use in Chrome. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/common/wm_window_property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/aura/wm_window_aura.h" 5 #include "ash/aura/wm_window_aura.h"
6 6
7 #include "ash/aura/aura_layout_manager_adapter.h" 7 #include "ash/aura/aura_layout_manager_adapter.h"
8 #include "ash/aura/wm_root_window_controller_aura.h" 8 #include "ash/aura/wm_root_window_controller_aura.h"
9 #include "ash/aura/wm_shell_aura.h" 9 #include "ash/aura/wm_shell_aura.h"
10 #include "ash/common/ash_constants.h" 10 #include "ash/common/ash_constants.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 #include "ui/wm/core/coordinate_conversion.h" 42 #include "ui/wm/core/coordinate_conversion.h"
43 #include "ui/wm/core/easy_resize_window_targeter.h" 43 #include "ui/wm/core/easy_resize_window_targeter.h"
44 #include "ui/wm/core/transient_window_manager.h" 44 #include "ui/wm/core/transient_window_manager.h"
45 #include "ui/wm/core/visibility_controller.h" 45 #include "ui/wm/core/visibility_controller.h"
46 #include "ui/wm/core/window_util.h" 46 #include "ui/wm/core/window_util.h"
47 47
48 DECLARE_WINDOW_PROPERTY_TYPE(ash::WmWindowAura*); 48 DECLARE_WINDOW_PROPERTY_TYPE(ash::WmWindowAura*);
49 49
50 namespace ash { 50 namespace ash {
51 51
52 DEFINE_WINDOW_PROPERTY_KEY(ShelfID, kShelfIDKey, kInvalidShelfID);
53 DEFINE_WINDOW_PROPERTY_KEY(int, kShelfItemTypeKey, TYPE_UNDEFINED);
54 DEFINE_WINDOW_PROPERTY_KEY(int,
55 kShelfIconResourceIdKey,
56 kInvalidImageResourceID);
57
58 DEFINE_OWNED_WINDOW_PROPERTY_KEY(WmWindowAura, kWmWindowKey, nullptr); 52 DEFINE_OWNED_WINDOW_PROPERTY_KEY(WmWindowAura, kWmWindowKey, nullptr);
59 53
60 static_assert(aura::Window::kInitialId == kShellWindowId_Invalid, 54 static_assert(aura::Window::kInitialId == kShellWindowId_Invalid,
61 "ids must match"); 55 "ids must match");
62 56
63 namespace { 57 namespace {
64 58
65 // A tentative class to set the bounds on the window. 59 // A tentative class to set the bounds on the window.
66 // TODO(oshima): Once all logic is cleaned up, move this to the real layout 60 // TODO(oshima): Once all logic is cleaned up, move this to the real layout
67 // manager with proper friendship. 61 // manager with proper friendship.
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 OnTransientChildAdded(this, Get(transient))); 886 OnTransientChildAdded(this, Get(transient)));
893 } 887 }
894 888
895 void WmWindowAura::OnTransientChildRemoved(aura::Window* window, 889 void WmWindowAura::OnTransientChildRemoved(aura::Window* window,
896 aura::Window* transient) { 890 aura::Window* transient) {
897 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_, 891 FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
898 OnTransientChildRemoved(this, Get(transient))); 892 OnTransientChildRemoved(this, Get(transient)));
899 } 893 }
900 894
901 } // namespace ash 895 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/common/wm_window_property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698