Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2381033002: Explicit control in tools of ANGLE frontend and backend (Closed)

Created:
4 years, 2 months ago by bsalomon
Modified:
4 years, 2 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Explicit control in tools of ANGLE frontend and backend Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Win-MSVC-ShuttleC-GPU-GTX960-x86_64-Debug-ANGLE-Trybot Committed: https://skia.googlesource.com/skia/+/11abd8d6cb2887bf66711863fb2dfe47da86d979

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix test for non-angle build #

Patch Set 4 : Update bot scripts #

Patch Set 5 : add new perf bot test expectation file #

Total comments: 6

Patch Set 6 : Address comments #

Patch Set 7 : work around uninit warning #

Patch Set 8 : Remove old angle cfg from swarming, don't test gl_es2 until debugged #

Patch Set 9 : rebase #

Patch Set 10 : Update to disable tests #

Patch Set 11 : retrain infra self test #

Patch Set 12 : rebase infra training #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -237 lines) Patch
M infra/bots/recipes/swarm_perf.py View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +5 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus5-GPU-Adreno330-arm-Debug-GN_Android.json View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus6-GPU-Adreno420-arm-Release-GN_Android.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-Nexus7-GPU-Tegra3-arm-Release-GN_Android.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Android-Clang-NexusPlayer-GPU-PowerVR-x86-Release-GN_Android.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-GN.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-GN.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
A + infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/Perf-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/big_issue_number.json View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M infra/bots/recipes/swarm_perf.expected/recipe_with_gerrit_patch.json View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_test.py View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-GPU-GTX960-x86_64-Debug-ANGLE.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tests/FloatingPointTextureTest.cpp View 1 2 3 4 5 6 7 8 9 2 chunks +15 lines, -2 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +11 lines, -1 line 0 comments Download
M tests/Test.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M tests/TestConfigParsing.cpp View 1 2 3 10 chunks +23 lines, -40 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 2 3 4 5 6 7 8 9 5 chunks +60 lines, -66 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 2 chunks +12 lines, -32 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 1 chunk +17 lines, -6 lines 0 comments Download
M tools/gpu/gl/angle/GLTestContext_angle.h View 1 2 3 4 5 1 chunk +14 lines, -8 lines 0 comments Download
M tools/gpu/gl/angle/GLTestContext_angle.cpp View 1 2 3 4 5 6 8 chunks +35 lines, -58 lines 0 comments Download

Messages

Total messages: 54 (45 generated)
bsalomon
PTAL
4 years, 2 months ago (2016-09-29 14:34:23 UTC) #4
Brian Osman
lgtm % nits https://codereview.chromium.org/2381033002/diff/70001/tools/flags/SkCommonFlagsConfig.cpp File tools/flags/SkCommonFlagsConfig.cpp (right): https://codereview.chromium.org/2381033002/diff/70001/tools/flags/SkCommonFlagsConfig.cpp#newcode248 tools/flags/SkCommonFlagsConfig.cpp:248: } nit: indentation https://codereview.chromium.org/2381033002/diff/70001/tools/gpu/gl/angle/GLTestContext_angle.cpp File tools/gpu/gl/angle/GLTestContext_angle.cpp ...
4 years, 2 months ago (2016-09-29 14:58:23 UTC) #5
bsalomon
https://codereview.chromium.org/2381033002/diff/70001/tools/flags/SkCommonFlagsConfig.cpp File tools/flags/SkCommonFlagsConfig.cpp (right): https://codereview.chromium.org/2381033002/diff/70001/tools/flags/SkCommonFlagsConfig.cpp#newcode248 tools/flags/SkCommonFlagsConfig.cpp:248: } On 2016/09/29 14:58:22, Brian Osman wrote: > nit: ...
4 years, 2 months ago (2016-09-29 16:48:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381033002/90001
4 years, 2 months ago (2016-09-29 16:48:39 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:90001) as https://skia.googlesource.com/skia/+/50094fb489543655df026be4e4f99e09e57a1f49
4 years, 2 months ago (2016-09-29 16:49:14 UTC) #11
bsalomon
A revert of this CL (patchset #6 id:90001) has been created in https://codereview.chromium.org/2384483003/ by bsalomon@google.com. ...
4 years, 2 months ago (2016-09-29 17:07:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381033002/110001
4 years, 2 months ago (2016-09-29 20:37:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381033002/210001
4 years, 2 months ago (2016-10-14 13:57:28 UTC) #52
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 15:13:52 UTC) #54
Message was sent while issue was closed.
Committed patchset #12 (id:210001) as
https://skia.googlesource.com/skia/+/11abd8d6cb2887bf66711863fb2dfe47da86d979

Powered by Google App Engine
This is Rietveld 408576698