Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2384503003: Move fpdfsdk/include to fpdfsdk (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -2248 lines) Patch
M BUILD.gn View 1 3 chunks +18 lines, -18 lines 0 comments Download
M core/fxge/skia/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/cba_annotiterator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cba_annotiterator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + fpdfsdk/cpdfsdk_annot.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_annot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/cpdfsdk_annothandlermgr.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
A + fpdfsdk/cpdfsdk_annotiterator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_annotiterator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fpdfsdk/cpdfsdk_baannot.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/cpdfsdk_baannothandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A + fpdfsdk/cpdfsdk_datetime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_datetime.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/cpdfsdk_document.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
A + fpdfsdk/cpdfsdk_environment.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_environment.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/cpdfsdk_interform.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
A + fpdfsdk/cpdfsdk_pageview.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + fpdfsdk/cpdfsdk_widget.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
A + fpdfsdk/cpdfsdk_widgethandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
A + fpdfsdk/cpdfsdk_xfawidget.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/cpdfsdk_xfawidgethandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + fpdfsdk/fsdk_actionhandler.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fsdk_baseform_embeddertest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + fpdfsdk/fsdk_common.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fsdk_define.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/fsdk_pauseadapter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fsdk_pauseadapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/include/cba_annotiterator.h View 1 chunk +0 lines, -48 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_annot.h View 1 chunk +0 lines, -65 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_annothandlermgr.h View 1 chunk +0 lines, -118 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_annotiterator.h View 1 chunk +0 lines, -31 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_baannot.h View 1 chunk +0 lines, -106 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_baannothandler.h View 1 chunk +0 lines, -110 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_datetime.h View 1 chunk +0 lines, -49 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_document.h View 1 chunk +0 lines, -108 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_environment.h View 1 chunk +0 lines, -178 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_interform.h View 1 chunk +0 lines, -144 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_pageview.h View 1 chunk +0 lines, -124 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_widget.h View 1 chunk +0 lines, -176 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_widgethandler.h View 1 chunk +0 lines, -119 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_xfawidget.h View 1 chunk +0 lines, -37 lines 0 comments Download
D fpdfsdk/include/cpdfsdk_xfawidgethandler.h View 1 chunk +0 lines, -108 lines 0 comments Download
D fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +0 lines, -118 lines 0 comments Download
D fpdfsdk/include/fsdk_common.h View 1 chunk +0 lines, -34 lines 0 comments Download
D fpdfsdk/include/fsdk_define.h View 1 chunk +0 lines, -121 lines 0 comments Download
D fpdfsdk/include/fsdk_pauseadapter.h View 1 chunk +0 lines, -25 lines 0 comments Download
D fpdfsdk/include/ipdfsdk_annothandler.h View 1 chunk +0 lines, -109 lines 0 comments Download
D fpdfsdk/include/pdfsdk_fieldaction.h View 1 chunk +0 lines, -39 lines 0 comments Download
A + fpdfsdk/ipdfsdk_annothandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/javascript/Annot.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/Field.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/pdfsdk_fieldaction.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfsdk_fieldaction.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2375963006 Patch 40001

Dependent Patchsets:

Issue 2380713005 Patch 30001

Messages

Total messages: 14 (10 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 17:22:06 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:52:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384503003/40001
4 years, 2 months ago (2016-09-30 00:05:34 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:18:27 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/114e46a1d97587973515e9aad7955e469c74...

Powered by Google App Engine
This is Rietveld 408576698