Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2380683007: 'icon' IDL attribute of HTMLMenuItemElement should reflect as URL. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

'icon' IDL attribute of HTMLMenuItemElement should reflect as URL. This resolve a local path issue of reflection-misc.html. The new behavior matches to Firefox. BUG=651664 Committed: https://crrev.com/06c4bb2566842d57a213983bc44f753e9b8206df Cr-Commit-Position: refs/heads/master@{#422058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -36 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-misc-expected.txt View 1 chunk +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMenuItemElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
kojii@, would you review this please?
4 years, 2 months ago (2016-09-30 05:50:48 UTC) #4
kojii
lgtm, nice!
4 years, 2 months ago (2016-09-30 07:41:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380683007/1
4 years, 2 months ago (2016-09-30 07:42:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 07:47:17 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 07:50:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06c4bb2566842d57a213983bc44f753e9b8206df
Cr-Commit-Position: refs/heads/master@{#422058}

Powered by Google App Engine
This is Rietveld 408576698