third_party/WebKit/Source/core/html/HTMLMenuItemElement.h - Issue 2380683007: 'icon' IDL attribute of HTMLMenuItemElement should reflect as URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMenuItemElement.h

Issue 2380683007: 'icon' IDL attribute of HTMLMenuItemElement should reflect as URL. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMenuItemElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLMenuItemElement.h b/third_party/WebKit/Source/core/html/HTMLMenuItemElement.h

index c007941703e6df8d0942d6082dcb8abe95a15d25..890a51cb881a78af1b62c9e03541fa6b5502f6bf 100644

--- a/third_party/WebKit/Source/core/html/HTMLMenuItemElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLMenuItemElement.h

@@ -16,6 +16,7 @@ public:

private:

explicit HTMLMenuItemElement(Document&);

+ bool isURLAttribute(const Attribute&) const override;

void defaultEventHandler(Event*) override;

};