third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp - Issue 2380683007: 'icon' IDL attribute of HTMLMenuItemElement should reflect as URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

Issue 2380683007: 'icon' IDL attribute of HTMLMenuItemElement should reflect as URL. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp b/third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

index eb25dbe661401c079a5cfd28aa7363e86c4f8b7c..4cca21cf967f724e6ab14c89ed2a7949d59dc4fe 100644

--- a/third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp

@@ -19,6 +19,11 @@ inline HTMLMenuItemElement::HTMLMenuItemElement(Document& document)

UseCounter::count(document, UseCounter::MenuItemElement);

}

+bool HTMLMenuItemElement::isURLAttribute(const Attribute& attribute) const

+ return attribute.name() == iconAttr || HTMLElement::isURLAttribute(attribute);

void HTMLMenuItemElement::defaultEventHandler(Event* event)

{

if (event->type() == EventTypeNames::click) {