SPv2: Add support for tracking raster paint invalidations in testing.

SPv2: Add support for tracking raster paint invalidations in testing.

Adds one test to demonstrate the output format and smoke test SPv2 paint invalidation.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a3396125b597b2c83bd7617405c44ecf8c958985
Cr-Commit-Position: refs/heads/master@{#422459}

[chrishtr, 2016-09-29 17:21:15]

Description was changed from

==========
none


none


Merge branch 'master' into paintinvalidationformat


none

BUG=
==========

to

==========
none


none


Merge branch 'master' into paintinvalidationformat


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-29 17:26:50]

Description was changed from

==========
none


none


Merge branch 'master' into paintinvalidationformat


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
SPv2: Add support for tracking raster paint invalidations in testing.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-30 00:13:46]

Description was changed from

==========
SPv2: Add support for tracking raster paint invalidations in testing.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
SPv2: Add support for tracking raster paint invalidations in testing.

Adds one test to demonstrate the output format and smoke test SPv2 paint
invalidation.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-09-30 00:18:00]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2016-09-30 00:18:04]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 00:18:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 00:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 00:22:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-09-30 00:47:01]

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h (right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h:87:
Vector<PaintInvalidationInfo> rasterInvalidationRects;
I suggest to keep this to still contain FloatRect, and create another field for
raster invalidation tracking, so that we don't need to allocate the additional
fields in the items of this vector when we are not tracking invalidations.

I think we should use "RasterInvalidation" instead of "PaintInvalidation" here.
We can distinguish them in SPv2.

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:612: }
Can you extract this as a function?

We can get the paintInvalidationReason from the
client.getPaintInvalidationReason() (for clients in the new display list, and
clients in old chunks matching new chunks).

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/paint/PaintInvalidationTracking.cpp
(right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintInvalidationTracking.cpp:77:

Can we move rect under-invalidation checking from GraphicsLayer to here (can be
in another patch)?

[chrishtr, 2016-09-30 18:19:11]

I renamed paint to raster throughout.

Also, as a followup patch, I will try to adjust the SPv1 raster invalidation
output format
to be agnostic to the layer tree structure. We might be able to get SPv2 outputs
to match
SPv1 outputs exactly for many tests.

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h (right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintChunk.h:87:
Vector<PaintInvalidationInfo> rasterInvalidationRects;
On 2016/09/30 at 00:47:00, Xianzhu wrote:
> I suggest to keep this to still contain FloatRect, and create another field
for raster invalidation tracking, so that we don't need to allocate the
additional fields in the items of this vector when we are not tracking
invalidations.
> 
> I think we should use "RasterInvalidation" instead of "PaintInvalidation"
here. We can distinguish them in SPv2.

Done.

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:612: }
On 2016/09/30 at 00:47:01, Xianzhu wrote:
> Can you extract this as a function?
> 
> We can get the paintInvalidationReason from the
client.getPaintInvalidationReason() (for clients in the new display list, and
clients in old chunks matching new chunks).

Done.

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/paint/PaintInvalidationTracking.cpp
(right):

https://codereview.chromium.org/2380683006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintInvalidationTracking.cpp:77:

On 2016/09/30 at 00:47:01, Xianzhu wrote:
> Can we move rect under-invalidation checking from GraphicsLayer to here (can
be in another patch)?

Ok will do that in a followup.

[chrishtr, 2016-09-30 18:23:36]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-30 19:04:30]

lgtm

https://codereview.chromium.org/2380683006/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):

https://codereview.chromium.org/2380683006/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:281: bool
m_isTrackingPaintInvalidations;
Nit: This seems not used.

[chrishtr, 2016-09-30 21:04:16]

https://codereview.chromium.org/2380683006/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):

https://codereview.chromium.org/2380683006/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:281: bool
m_isTrackingPaintInvalidations;
On 2016/09/30 at 19:04:30, Xianzhu wrote:
> Nit: This seems not used.

Fixed.

[chrishtr, 2016-09-30 21:04:54]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-30 21:04:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps180001
(title: "none")

[commit-bot: I haz the power, 2016-09-30 21:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:22:33]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[chrishtr, 2016-09-30 22:11:58]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-30 22:11:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps200001
(title: "none")

[commit-bot: I haz the power, 2016-09-30 22:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-09-30 22:30:24]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 22:31:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 00:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:04:01]

Dry run: Exceeded global retry quota

[chrishtr, 2016-10-01 04:27:17]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-01 04:27:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps240001
(title: "none")

[commit-bot: I haz the power, 2016-10-01 04:27:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 04:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 04:36:10]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chrishtr, 2016-10-01 04:42:48]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-01 04:42:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps260001
(title: "none")

[commit-bot: I haz the power, 2016-10-01 04:43:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 05:26:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 05:26:14]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-01 20:08:58]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-01 20:08:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps280001
(title: "none")

[commit-bot: I haz the power, 2016-10-01 20:09:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 20:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 20:49:42]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-01 22:40:29]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-01 22:40:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps300001
(title: "none")

[commit-bot: I haz the power, 2016-10-01 22:40:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 23:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 23:13:06]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-10-02 14:38:24]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-02 14:38:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps320001
(title: "none")

[commit-bot: I haz the power, 2016-10-02 14:38:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 15:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 15:36:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-10-03 16:28:10]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-03 16:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2380683006/#ps340001
(title: "none")

[commit-bot: I haz the power, 2016-10-03 16:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:05:23]

Committed patchset #18 (id:340001)

[commit-bot: I haz the power, 2016-10-03 18:07:01]

Description was changed from

==========
SPv2: Add support for tracking raster paint invalidations in testing.

Adds one test to demonstrate the output format and smoke test SPv2 paint
invalidation.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
SPv2: Add support for tracking raster paint invalidations in testing.

Adds one test to demonstrate the output format and smoke test SPv2 paint
invalidation.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/a3396125b597b2c83bd7617405c44ecf8c958985
Cr-Commit-Position: refs/heads/master@{#422459}
==========

[commit-bot: I haz the power, 2016-10-03 18:07:03]

Patchset 18 (id:??) landed as
https://crrev.com/a3396125b597b2c83bd7617405c44ecf8c958985
Cr-Commit-Position: refs/heads/master@{#422459}