[SPv2] Introduce an option to output the GraphicsLayer tree as a flat layer list.

[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow most (all?) SPv2 paint invalidation tests to pass without
any changes to expectation files.

BUG=647831
Committed: https://crrev.com/546bb10762285d9d94d0d34d0305d5191ea05d18
Cr-Commit-Position: refs/heads/master@{#422515}

[chrishtr, 2016-09-30 22:49:50]

Description was changed from

==========
none


none


none


Merge branch 'paintinvalidationformat' into invalidationmatch


none


Merge branch 'paintinvalidationformat' into invalidationmatch


none


Merge branch 'paintinvalidationformat' into invalidationmatch


none

BUG=
==========

to

==========
[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow SPv2 most (all?) paint invalidation tests to pass without
any changes to expectation files.

BUG=647831
==========

[chrishtr, 2016-09-30 22:51:13]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2016-09-30 22:51:26]

Description was changed from

==========
[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow SPv2 most (all?) paint invalidation tests to pass without
any changes to expectation files.

BUG=647831
==========

to

==========
[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow most (all?) SPv2 paint invalidation tests to pass without
any changes to expectation files.

BUG=647831
==========

[Xianzhu, 2016-09-30 23:19:38]

lgtm

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.idl:190: const unsigned short
OUTPUT_CHILDREN_AS_LAYER_LIST = 64;
Nit: Should we use the same prefix as the existing flags?

[chrishtr, 2016-09-30 23:20:53]

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.idl:190: const unsigned short
OUTPUT_CHILDREN_AS_LAYER_LIST = 64;
On 2016/09/30 at 23:19:38, Xianzhu wrote:
> Nit: Should we use the same prefix as the existing flags?

The other ones all say LAYER_TREE, which seemed confusing to combine with
LAYER_LIST in the same breath.

[Xianzhu, 2016-10-01 00:14:03]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-10-01 00:14:04]

lgtm

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/testing/Internals.idl (right):

https://codereview.chromium.org/2383323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/testing/Internals.idl:190: const unsigned short
OUTPUT_CHILDREN_AS_LAYER_LIST = 64;
On 2016/09/30 23:20:53, chrishtr wrote:
> On 2016/09/30 at 23:19:38, Xianzhu wrote:
> > Nit: Should we use the same prefix as the existing flags?
> 
> The other ones all say LAYER_TREE, which seemed confusing to combine with
> LAYER_LIST in the same breath.

Acknowledged.

[commit-bot: I haz the power, 2016-10-01 00:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:14:30]

This CL has an open dependency (Issue 2380683006 Patch 220001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[chrishtr, 2016-10-03 18:30:48]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-10-03 18:30:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2383323002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-10-03 18:32:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:30:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-03 20:33:42]

Description was changed from

==========
[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow most (all?) SPv2 paint invalidation tests to pass without
any changes to expectation files.

BUG=647831
==========

to

==========
[SPv2] Introduce option to output the GraphicsLayerTree as a flat layer list.

This should allow most (all?) SPv2 paint invalidation tests to pass without
any changes to expectation files.

BUG=647831

Committed: https://crrev.com/546bb10762285d9d94d0d34d0305d5191ea05d18
Cr-Commit-Position: refs/heads/master@{#422515}
==========

[commit-bot: I haz the power, 2016-10-03 20:33:44]

Patchset 3 (id:??) landed as
https://crrev.com/546bb10762285d9d94d0d34d0305d5191ea05d18
Cr-Commit-Position: refs/heads/master@{#422515}