Enable goma on pdfium buildbots by default.

Enable goma on pdfium buildbots by default.

This CL is reland of https://codereview.chromium.org/2367263002/
fix: use close_fds in goma module https://codereview.chromium.org/2374543005/

BUG=643139
Committed: https://chromium.googlesource.com/chromium/tools/build/+/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976

[tikuta, 2016-09-28 05:39:45]

tikuta@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org

[tikuta, 2016-09-28 05:39:46]

PTAL.

diff of pdfium.py is not different from the last reverted CL.
subprocess.Popen in goma module was fixed for windows.

[tikuta, 2016-09-28 05:40:29]

The CQ bit was checked by tikuta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 05:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 05:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 05:44:48]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-09-28 16:17:54]

lgtm

[Paweł Hajdan Jr., 2016-09-28 19:08:56]

LGTM

[tikuta, 2016-09-29 01:59:20]

Thank you for review.
I commit this and rebuild latest success build of following buildbot to check
this recipes.

https://build.chromium.org/p/client.pdfium/console
https://build.chromium.org/p/tryserver.client.pdfium/console

[tikuta, 2016-09-29 01:59:30]

The CQ bit was checked by tikuta@chromium.org

[commit-bot: I haz the power, 2016-09-29 01:59:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 02:04:00]

Description was changed from

==========
Enable goma on pdfium buildbots by default.

This CL is reland of https://codereview.chromium.org/2367263002/
fix: use close_fds in goma module https://codereview.chromium.org/2374543005/

BUG=643139
==========

to

==========
Enable goma on pdfium buildbots by default.

This CL is reland of https://codereview.chromium.org/2367263002/
fix: use close_fds in goma module https://codereview.chromium.org/2374543005/

BUG=643139

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/d1a446fed9dca1ce0cdf...
==========

[commit-bot: I haz the power, 2016-09-29 02:04:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/d1a446fed9dca1ce0cdf...

[tikuta, 2016-09-29 02:15:08]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2377193002/ by tikuta@chromium.org.

The reason for reverting is:
https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows

https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/...

Traceback (most recent call last):
  File
"E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py",
line 63, in <module>
    sys.exit(main())
  File
"E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py",
line 52, in main
    start_cloudtail(args)
  File
"E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py",
line 26, in start_cloudtail
    close_fds=True)
  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 666, in __init__
    raise ValueError("close_fds is not supported on Windows "
ValueError: close_fds is not supported on Windows platforms if you redirect
stdin/stdout/stderr.