|
Revert of Enable goma on pdfium buildbots by default. (patchset #1 id:1 of https://codereview.chromium.org/2380553002/ )
Reason for revert:
https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows
https://uberchromegw.corp.google.com/i/client.pdfium/builders/windows/builds/1680/steps/start%20cloudtail/logs/stdio
Traceback (most recent call last):
File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 63, in <module>
sys.exit(main())
File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 52, in main
start_cloudtail(args)
File "E:\b\build\scripts/slave\recipe_modules\goma\resources\cloudtail_utils.py", line 26, in start_cloudtail
close_fds=True)
File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 666, in __init__
raise ValueError("close_fds is not supported on Windows "
ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr
Original issue's description:
> Enable goma on pdfium buildbots by default.
>
> This CL is reland of https://codereview.chromium.org/2367263002/
> fix: use close_fds in goma module https://codereview.chromium.org/2374543005/
>
> BUG= 643139
>
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/d1a446fed9dca1ce0cdf0d5abdc2b5e45b4e9976
TBR=phajdan.jr@chromium.org,dpranke@chromium.org,thestig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 643139
Committed: https://chromium.googlesource.com/chromium/tools/build/+/a172c75dec9d8a53ac11e7cca4944b737a75d50f
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+72 lines, -4453 lines) |
Patch |
|
M |
scripts/slave/recipes/pdfium.py
|
View
|
|
5 chunks |
+3 lines, -14 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/android.json
|
View
|
|
2 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/drm_win_xfa.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_asan_lsan.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_no_v8.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_skia.json
|
View
|
|
2 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_xfa.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_xfa_asan_lsan.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/mac.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/mac_no_v8.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/mac_skia.json
|
View
|
|
2 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/mac_xfa.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan_lsan.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_no_v8.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_skia.json
|
View
|
|
2 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_xfa.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_xfa_32.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_xfa_clang.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
|
M |
scripts/slave/recipes/pdfium.expected/win_xfa_rel.json
|
View
|
|
3 chunks |
+3 lines, -193 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|