Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: content/browser/frame_host/navigator.h

Issue 2380383004: Fix aborted navigates not clearing the pending navigation entry with PlzNavigate. (Closed)
Patch Set: more targeted fix without treating this as failednavigation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator.h
diff --git a/content/browser/frame_host/navigator.h b/content/browser/frame_host/navigator.h
index 1580753ec3ed0ed39d8bb14017c215f9625e6d24..61d9e1374f0675083767dca7281cc63b91e46326 100644
--- a/content/browser/frame_host/navigator.h
+++ b/content/browser/frame_host/navigator.h
@@ -188,6 +188,10 @@ class CONTENT_EXPORT Navigator : public base::RefCounted<Navigator> {
virtual NavigationHandleImpl* GetNavigationHandleForFrameHost(
RenderFrameHostImpl* render_frame_host);
+ // Called when a navigation has failed or the response is 204/205 to discard
+ // the pending entry in order to avoid url spoofs.
+ virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {}
+
protected:
friend class base::RefCounted<Navigator>;
virtual ~Navigator() {}
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698