Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 2380383004: Fix aborted navigates not clearing the pending navigation entry with PlzNavigate. (Closed)
Patch Set: more targeted fix without treating this as failednavigation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index a0574a98ce62add89d6fecbf8f9ca68c9f518458..e5af29e8993b4acef5334dd2e6b4bfe5dc4ba019 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -97,6 +97,7 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
void CancelNavigation(FrameTreeNode* frame_tree_node) override;
NavigationHandleImpl* GetNavigationHandleForFrameHost(
RenderFrameHostImpl* render_frame_host) override;
+ void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) override;
private:
// Holds data used to track browser side navigation metrics.
@@ -145,10 +146,6 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
SiteInstanceImpl* site_instance,
NavigationHandleImpl* navigation_handle);
- // Called when a navigation has failed to discard the pending entry in order
- // to avoid url spoofs.
- void DiscardPendingEntryOnFailureIfNeeded(NavigationHandleImpl* handle);
-
// The NavigationController that will keep track of session history for all
// RenderFrameHost objects using this NavigatorImpl.
// TODO(nasko): Move ownership of the NavigationController from
« no previous file with comments | « content/browser/frame_host/navigator.h ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698