Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: content/browser/frame_host/navigator.h

Issue 2380383004: Fix aborted navigates not clearing the pending navigation entry with PlzNavigate. (Closed)
Patch Set: more targeted fix without treating this as failednavigation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/browser/frame_host/navigator_delegate.h" 10 #include "content/browser/frame_host/navigator_delegate.h"
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 const base::TimeTicks& renderer_before_unload_end_time) {} 181 const base::TimeTicks& renderer_before_unload_end_time) {}
182 182
183 // Returns the NavigationHandle associated with a navigation in 183 // Returns the NavigationHandle associated with a navigation in
184 // |render_frame_host|. Normally, each frame can have its own 184 // |render_frame_host|. Normally, each frame can have its own
185 // NavigationHandle. However, in the case of a navigation to an interstitial 185 // NavigationHandle. However, in the case of a navigation to an interstitial
186 // page, there's just one NavigationHandle for the whole page (since it's 186 // page, there's just one NavigationHandle for the whole page (since it's
187 // assumed to only have one RenderFrameHost and navigate once). 187 // assumed to only have one RenderFrameHost and navigate once).
188 virtual NavigationHandleImpl* GetNavigationHandleForFrameHost( 188 virtual NavigationHandleImpl* GetNavigationHandleForFrameHost(
189 RenderFrameHostImpl* render_frame_host); 189 RenderFrameHostImpl* render_frame_host);
190 190
191 // Called when a navigation has failed or the response is 204/205 to discard
192 // the pending entry in order to avoid url spoofs.
193 virtual void DiscardPendingEntryIfNeeded(NavigationHandleImpl* handle) {}
194
191 protected: 195 protected:
192 friend class base::RefCounted<Navigator>; 196 friend class base::RefCounted<Navigator>;
193 virtual ~Navigator() {} 197 virtual ~Navigator() {}
194 }; 198 };
195 199
196 } // namespace content 200 } // namespace content
197 201
198 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_ 202 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698