Use sequence<T> instead of T[] where possible and document exceptions

Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722
Committed: https://crrev.com/3f6de63d8a003897255fcd83f51d47a3bf73bf31
Cr-Commit-Position: refs/heads/master@{#422751}

[foolip, 2016-10-01 22:12:07]

Description was changed from

==========
less []

BUG=
==========

to

==========
Use sequence<T> instead of T[] where possible and document exceptions
==========

[foolip, 2016-10-01 22:39:46]

Description was changed from

==========
Use sequence<T> instead of T[] where possible and document exceptions
==========

to

==========
Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722
==========

[foolip, 2016-10-01 22:41:20]

foolip@chromium.org changed reviewers:
+ jsbell@chromium.org, jyasskin@chromium.org, nhiroki@chromium.org,
wolenetz@chromium.org

[foolip, 2016-10-01 22:41:21]

Reviewers, you have all ended up in one or more TODOs based on git blame. I can
use TODO(foolip) instead if you prefer.

[nhiroki, 2016-10-02 23:39:02]

StorageQuota.idl lgtm

[haraken, 2016-10-03 01:08:31]

LGTM

[jsbell, 2016-10-03 16:41:48]

lgtm

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl
(right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl:36:
// TODO(jsbell): |webkitEntries| should be FrozenArray<Entry>.
Did you try switching and note failures? Or just not try since it would have
changed generated code?

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/StorageQuota.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageQuota.idl:44: // TODO(nhiroki):
|supportedTypes| should be FrozenArray<StorageType>.
You can give this one to me.

[Jeffrey Yasskin, 2016-10-03 16:58:38]

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl:20: //
TODO(jyasskin): |uuids| should be FrozenArray<UUID>.
LGTM. You could also put "deprecate uuids" due to
https://github.com/WebBluetoothCG/web-bluetooth/pull/292.

[wolenetz, 2016-10-03 20:53:03]

mediasource lgtm % nit

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/TrackDefault.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/TrackDefault.idl:19: //
TODO(wolenetz): |kinds| should be FrozenArray<DOMString>.
LGTM % reference https://crbug.com/619665 here please. Note, v1 MSE spec dropped
this feature, but it'll likely come back in incubation. Right before it was
dropped, this attribute was changed to sequence<DOMString> getKinds() accessor.
That crbug tracks updating this object to that latter change.

[foolip, 2016-10-04 10:02:20]

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl:20: //
TODO(jyasskin): |uuids| should be FrozenArray<UUID>.
On 2016/10/03 16:58:37, Jeffrey Yasskin wrote:
> LGTM. You could also put "deprecate uuids" due to
> https://github.com/WebBluetoothCG/web-bluetooth/pull/292.

Went with "|uuids| was FrozenArray<UUID>, now removed" and PR link.

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl
(right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl:36:
// TODO(jsbell): |webkitEntries| should be FrozenArray<Entry>.
On 2016/10/03 16:41:47, jsbell wrote:
> Did you try switching and note failures? Or just not try since it would have
> changed generated code?

I thought it'd be easier to not change the generated code, to avoid reverting
everything in case of regressions. But I can follow up with an attempt to
convert some of these to FrozenArray<T>.

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasource/TrackDefault.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasource/TrackDefault.idl:19: //
TODO(wolenetz): |kinds| should be FrozenArray<DOMString>.
On 2016/10/03 20:53:03, wolenetz wrote:
> LGTM % reference https://crbug.com/619665 here please. Note, v1 MSE spec
dropped
> this feature, but it'll likely come back in incubation. Right before it was
> dropped, this attribute was changed to sequence<DOMString> getKinds()
accessor.
> That crbug tracks updating this object to that latter change.

Referencing https://crbug.com/619665 and
https://github.com/w3c/media-source/issues/91.

FWIW, if the constructor is the only way to create an object like this, I think
that a [SameObject] FrozenArray<DOMString> would have been more in line with
other APIs like https://notifications.spec.whatwg.org/#api

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/quota/StorageQuota.idl (right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/quota/StorageQuota.idl:44: // TODO(nhiroki):
|supportedTypes| should be FrozenArray<StorageType>.
On 2016/10/03 16:41:47, jsbell wrote:
> You can give this one to me.

Done.

[foolip, 2016-10-04 10:03:42]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-04 10:03:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jyasskin@chromium.org, jsbell@chromium.org,
nhiroki@chromium.org, wolenetz@chromium.org
Link to the patchset: https://codereview.chromium.org/2380383003/#ps40001
(title: "address feedback")

[commit-bot: I haz the power, 2016-10-04 10:04:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-10-04 10:12:27]

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl
(right):

https://codereview.chromium.org/2380383003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl:36:
// TODO(jsbell): |webkitEntries| should be FrozenArray<Entry>.
On 2016/10/04 10:02:20, foolip wrote:
> On 2016/10/03 16:41:47, jsbell wrote:
> > Did you try switching and note failures? Or just not try since it would have
> > changed generated code?
> 
> I thought it'd be easier to not change the generated code, to avoid reverting
> everything in case of regressions. But I can follow up with an attempt to
> convert some of these to FrozenArray<T>.

Actually, I won't, not today. Each case is different in terms of when it should
return the same object and not and would require tests to verify the right
behavior, while mass conversion would probably work out in terms of compat, it's
probably best to do the changes attribute-by-attribute and get the
[SameObject]-ness right in the same CLs.

[commit-bot: I haz the power, 2016-10-04 11:17:41]

Description was changed from

==========
Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722
==========

to

==========
Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722
==========

[commit-bot: I haz the power, 2016-10-04 11:17:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 11:19:07]

Description was changed from

==========
Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722
==========

to

==========
Use sequence<T> instead of T[] where possible and document exceptions

This does not change the generated code at all.

BUG=460722

Committed: https://crrev.com/3f6de63d8a003897255fcd83f51d47a3bf73bf31
Cr-Commit-Position: refs/heads/master@{#422751}
==========

[commit-bot: I haz the power, 2016-10-04 11:19:09]

Patchset 3 (id:??) landed as
https://crrev.com/3f6de63d8a003897255fcd83f51d47a3bf73bf31
Cr-Commit-Position: refs/heads/master@{#422751}