third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl - Issue 2380383003: Use sequence<T> instead of T[] where possible and document exceptions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl

Issue 2380383003: Use sequence<T> instead of T[] where possible and document exceptions (Closed)

Patch Set: more Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/Internals.idl ('k') | third_party/WebKit/Source/modules/crypto/CryptoKey.idl » ('j') | third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://webbluetoothchrome.github.io/web-bluetooth/#idl-def-bluetoothdevice	5 // https://webbluetoothchrome.github.io/web-bluetooth/#idl-def-bluetoothdevice

6	6

7 // Implement BluetoothDevice interface: http://crbug.com/421668	7 // Implement BluetoothDevice interface: http://crbug.com/421668

8	8

9 [	9 [

10 DependentLifetime,	10 DependentLifetime,

11 OriginTrialEnabled=WebBluetooth,	11 OriginTrialEnabled=WebBluetooth,

12 ] interface BluetoothDevice : EventTarget	12 ] interface BluetoothDevice : EventTarget

13 // Implement ServiceEventHandlers interface: http://crbug.com/421670	13 // Implement ServiceEventHandlers interface: http://crbug.com/421670

14 // : ServiceEventHandlers	14 // : ServiceEventHandlers

15 {	15 {

16 // Implement BluetoothDevice interface: http://crbug.com/421668	16 // Implement BluetoothDevice interface: http://crbug.com/421668

17 readonly attribute DOMString id;	17 readonly attribute DOMString id;

18 readonly attribute DOMString? name;	18 readonly attribute DOMString? name;

19 readonly attribute BluetoothRemoteGATTServer gatt;	19 readonly attribute BluetoothRemoteGATTServer gatt;

	20 // TODO(jyasskin): \|uuids\| should be FrozenArray<UUID>.
	Jeffrey Yasskin 2016/10/03 16:58:37 LGTM. You could also put "deprecate uuids" due to LGTM. You could also put "deprecate uuids" due to https://github.com/WebBluetoothCG/web-bluetooth/pull/292. foolip 2016/10/04 10:02:20 Went with "\|uuids\| was FrozenArray<UUID>, now remo Show quoted text On 2016/10/03 16:58:37, Jeffrey Yasskin wrote: > LGTM. You could also put "deprecate uuids" due to > https://github.com/WebBluetoothCG/web-bluetooth/pull/292. Went with "\|uuids\| was FrozenArray<UUID>, now removed" and PR link.
20 readonly attribute UUID[] uuids;	21 readonly attribute UUID[] uuids;

21	22

22 attribute EventHandler ongattserverdisconnected;	23 attribute EventHandler ongattserverdisconnected;

23 };	24 };

OLD	NEW