third_party/WebKit/Source/core/frame/Location.idl - Issue 2380383003: Use sequence<T> instead of T[] where possible and document exceptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Location.idl

Issue 2380383003: Use sequence<T> instead of T[] where possible and document exceptions (Closed)

Patch Set: address feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/Location.idl

diff --git a/third_party/WebKit/Source/core/frame/Location.idl b/third_party/WebKit/Source/core/frame/Location.idl

index a2760f6536d75beee8f4d18b982cbe0c365a836e..02bf37b7a18aa559a096dfa0ccbf8929342f9913 100644

--- a/third_party/WebKit/Source/core/frame/Location.idl

+++ b/third_party/WebKit/Source/core/frame/Location.idl

@@ -41,8 +41,8 @@

[CallWith=(CurrentWindow,EnteredWindow), DoNotCheckSecurity, RaisesException] void replace(DOMString url);

[CallWith=CurrentWindow] void reload();

- // TODO(foolip): ancestorOrigins should have [SameObject] and be of type

- // DOMString[], i.e. it should return the same array every time.

+ // TODO(foolip): |ancestorOrigins| should have [Unforgeable, SameObject] and

+ // be of type FrozenArray<USVString>.

[Measure] readonly attribute DOMStringList ancestorOrigins;

// TODO(foolip): Per spec, Location implements URLUtils. The below is