[ARC] Converts parts of ios/web/web_state to ARC.

[ARC] Converts parts of ios/web/web_state to ARC.

Notable changes:
 * CRWWebViewProxyImpl now uses synthesized getter and ivar for
property contentView
 * CRWJSPOSTRequestLoader now does not create a retain cycle of
CRWWKScriptMessageRouter objects. The cycle seems to have been harmless,
but it definitely brings no value, and it's better to not have it.

BUG=651830
Committed: https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef
Cr-Commit-Position: refs/heads/master@{#422776}

[stkhapugin, 2016-09-30 14:23:50]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 14:24:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 15:49:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 15:49:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[stkhapugin, 2016-10-03 09:58:21]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 09:58:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 10:45:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 10:45:54]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2016-10-04 12:33:57]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2016-10-04 12:34:10]

The CQ bit was unchecked by stkhapugin@chromium.org

[stkhapugin, 2016-10-04 12:34:27]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org

[stkhapugin, 2016-10-04 12:34:27]

ptal

[marq (ping after 24h), 2016-10-04 12:49:05]

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
File ios/web/web_state/crw_web_view_scroll_view_proxy.mm (right):

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
ios/web/web_state/crw_web_view_scroll_view_proxy.mm:7: #import <objc/runtime.h>
Is this needed?

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
ios/web/web_state/crw_web_view_scroll_view_proxy.mm:20:
base::scoped_nsobject<id> _observers;
Why not convert this to a strong property as well? Or is that happening in a
different set of changes?

[stkhapugin, 2016-10-04 13:02:50]

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
File ios/web/web_state/crw_web_view_scroll_view_proxy.mm (right):

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
ios/web/web_state/crw_web_view_scroll_view_proxy.mm:7: #import <objc/runtime.h>
On 2016/10/04 12:49:05, marq wrote:
> Is this needed?

Yes, before it was transitevly included from base/ios/weak_nsobject.h

https://codereview.chromium.org/2380323002/diff/1/ios/web/web_state/crw_web_v...
ios/web/web_state/crw_web_view_scroll_view_proxy.mm:20:
base::scoped_nsobject<id> _observers;
On 2016/10/04 12:49:05, marq wrote:
> Why not convert this to a strong property as well? Or is that happening in a
> different set of changes?

The plan is to remove scoped_nsobject boilerplate at a later stage, yes. Doing
this now will generate a lot more changed code, which will put a lot of load on
reviewers.

[marq (ping after 24h), 2016-10-04 13:04:18]

lgtm

[stkhapugin, 2016-10-04 13:05:02]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:05:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:55:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 13:57:41]

Description was changed from

==========
[ARC] Converts parts of ios/web/web_state to ARC.

Notable changes:
 * CRWWebViewProxyImpl now uses synthesized getter and ivar for
property contentView
 * CRWJSPOSTRequestLoader now does not create a retain cycle of
CRWWKScriptMessageRouter objects. The cycle seems to have been harmless,
but it definitely brings no value, and it's better to not have it.

BUG=651830
==========

to

==========
[ARC] Converts parts of ios/web/web_state to ARC.

Notable changes:
 * CRWWebViewProxyImpl now uses synthesized getter and ivar for
property contentView
 * CRWJSPOSTRequestLoader now does not create a retain cycle of
CRWWKScriptMessageRouter objects. The cycle seems to have been harmless,
but it definitely brings no value, and it's better to not have it.

BUG=651830

Committed: https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef
Cr-Commit-Position: refs/heads/master@{#422776}
==========

[commit-bot: I haz the power, 2016-10-04 13:57:42]

Patchset 1 (id:??) landed as
https://crrev.com/2a4ea729584ef7faa36d2f64db26b09bd14122ef
Cr-Commit-Position: refs/heads/master@{#422776}