Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2396553002: [ARC] Converts part of ios/web/ui to ARC.

Created:
4 years, 2 months ago by stkhapugin
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ARC] Converts part of ios/web/ui to ARC. Notable changes: * crw_web_controller.mm used to have a dictionary storing selectors just for keeping the KVO code clean. ARC cannot call a selector from a string like this, because it cannot guarantee correct memory management in this case. So it was replaced with an array of observed key paths to keep some of the code cleanness, while the KVO callback has a huge switch. * Filed crbug.com/652732 for unremovable WeakNSProtocols in some headers BUG=651830

Patch Set 1 #

Patch Set 2 : asdf #

Patch Set 3 : asdf #

Patch Set 4 : co #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -267 lines) Patch
M ios/web/BUILD.gn View 1 2 3 chunks +65 lines, -65 lines 0 comments Download
M ios/web/public/origin_util.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/url_schemes.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_client.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/crw_web_view_scroll_view_proxy.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ios/web/public/web_state/page_display_state.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/ui/crw_generic_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_web_view_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/blocked_popup_info.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/context_menu_params.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader.mm View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M ios/web/web_state/crw_web_view_proxy_impl.mm View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M ios/web/web_state/crw_web_view_scroll_view_proxy.mm View 1 2 5 chunks +12 lines, -10 lines 0 comments Download
M ios/web/web_state/error_translation_util.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/global_web_state_event_tracker.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/credential_util.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager.mm View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_receiver.mm View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_plugin_placeholder_manager.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_post_request_loader.mm View 1 2 5 chunks +15 lines, -11 lines 0 comments Download
M ios/web/web_state/js/crw_js_window_id_manager.mm View 1 5 chunks +9 lines, -5 lines 0 comments Download
M ios/web/web_state/js/page_script_util.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/page_viewport_state.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_generic_content_view.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_touch_tracking_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_touch_tracking_recognizer.mm View 1 1 chunk +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +7 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 38 chunks +105 lines, -125 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 1 2 10 chunks +22 lines, -16 lines 0 comments Download
M ios/web/web_state/ui/crw_web_view_content_view.mm View 1 2 chunks +6 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
stkhapugin
PTAL
4 years, 2 months ago (2016-10-07 09:25:56 UTC) #6
stkhapugin
4 years, 2 months ago (2016-10-07 09:26:21 UTC) #7
Oops, disregard this CL, wrong tab!

Powered by Google App Engine
This is Rietveld 408576698