Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2379923002: Implement "appinstalled" event on Android. (Closed)
Patch Set: Blink style. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 20bff4cce5498300ed8d62446cfa00b5ceac347c..3da0ca4d2df9441e9925dc66e8d019a2050c0edf 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -17,6 +17,7 @@
#include "content/public/browser/web_contents_observer.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom.h"
+#include "third_party/WebKit/public/platform/modules/installation/installation.mojom.h"
class SkBitmap;
struct WebApplicationInfo;
@@ -71,6 +72,11 @@ class AppBannerManager : public content::WebContentsObserver,
// pipeline will be reported to the devtools console.
virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
+ // Informs the page that it has been installed via an app banner.
+ // This is redundant for the beforeinstallprompt event's promise being
+ // resolved, but is required by the install event spec.
+ void OnInstall();
+
// Sends a message to the renderer that the user accepted the banner. Does
// nothing if |request_id| does not match the current request.
void SendBannerAccepted(int request_id);
@@ -272,6 +278,9 @@ class AppBannerManager : public content::WebContentsObserver,
// Whether the installable status has been logged for this run.
bool need_to_log_status_;
+ // Service to send events to the renderer.
+ blink::mojom::InstallationServicePtr installation_service_;
dominickn 2016/12/09 06:08:17 This is a one-way message (no callback). No need f
Matt Giuca 2016/12/12 04:28:20 Same question as on the other one.
+
// The concrete subclasses of this class are expected to have their lifetimes
// scoped to the WebContents which they are observing. This allows us to use
// weak pointers for callbacks.

Powered by Google App Engine
This is Rietveld 408576698