Implement "appinstalled" event on Android.

chrome/browser/banners/app_banner_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/engagement/site_engagement_observer.h"
 #include "chrome/browser/installable/installable_logging.h"
 #include "chrome/browser/installable/installable_manager.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "third_party/WebKit/public/platform/modules/app_banner/app_banner.mojom.h"
+#include "third_party/WebKit/public/platform/modules/installation/installation.mojom.h"
 
 class SkBitmap;
 struct WebApplicationInfo;
 
 namespace content {
 class RenderFrameHost;
 class WebContents;
 }
 
 // This forward declaration exists solely for the DidFinishCreatingBookmarkApp
@@ skipping 34 matching lines @@
   static void SetEngagementWeights(double direct_engagement,
                                    double indirect_engagement);
 
   // Returns whether or not the URLs match for everything except for the ref.
   static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);
 
   // Requests an app banner. If |is_debug_mode| is true, any failure in the
   // pipeline will be reported to the devtools console.
   virtual void RequestAppBanner(const GURL& validated_url, bool is_debug_mode);
 
+  // Informs the page that it has been installed via an app banner.
+  // This is redundant for the beforeinstallprompt event's promise being
+  // resolved, but is required by the install event spec.
+  void OnInstall();
+
   // Sends a message to the renderer that the user accepted the banner. Does
   // nothing if |request_id| does not match the current request.
   void SendBannerAccepted(int request_id);
 
   // Sends a message to the renderer that the user dismissed the banner. Does
   // nothing if |request_id| does not match the current request.
   void SendBannerDismissed(int request_id);
 
   // Overridden and passed through base::Bind on desktop platforms. Called when
   // the bookmark app install initiated by a banner has completed. Not used on
@@ skipping 181 matching lines @@
   // requests for it to be shown later on.
   bool was_canceled_by_page_;
   bool page_requested_prompt_;
 
   // Whether we should be logging errors to the console for this request.
   bool is_debug_mode_;
 
   // Whether the installable status has been logged for this run.
   bool need_to_log_status_;
 
+  // Service to send events to the renderer.
+  blink::mojom::InstallationServicePtr installation_service_;

[dominickn, 2016/12/09 06:08:17]

This is a one-way message (no callback). No need for the pointer to be a member;
just make it a local variable in OnInstall.

[Matt Giuca, 2016/12/12 04:28:20]

Same question as on the other one.

+
   // The concrete subclasses of this class are expected to have their lifetimes
   // scoped to the WebContents which they are observing. This allows us to use
   // weak pointers for callbacks.
   base::WeakPtrFactory<AppBannerManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_