Implement "appinstalled" event on Android.

chrome/browser/banners/app_banner_manager.cc

Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index bad00344b52368bea0cd80bbc2e25dece364427c..a971318b9a5f0a2816744b17ff920203bc53729e 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -23,6 +23,7 @@
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/origin_util.h"
+#include "mojo/public/cpp/bindings/interface_request.h"

[dominickn, 2016/12/09 06:08:17]

Is this include necessary? We're already calling GetInterface in here without
it.

[Matt Giuca, 2016/12/12 04:28:19]

Done.

 #include "services/service_manager/public/cpp/interface_provider.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/display/display.h"
@@ -132,6 +133,15 @@ void AppBannerManager::RequestAppBanner(const GURL& validated_url,
       base::Bind(&AppBannerManager::OnDidGetManifest, GetWeakPtr()));
 }
 
+void AppBannerManager::OnInstall() {
+  if (!installation_service_) {

[dominickn, 2016/12/09 06:08:17]

As noted in the header file, just made this a local variable in here.

[Matt Giuca, 2016/12/12 04:28:20]

Are there performance issues about calling GetMainFrame, GetRemoteInterfaces,
GetInterface and GetProxy every time?

(Can you link to a precedent for not caching this?)

[dominickn, 2016/12/12 05:03:30]

1) this isn't a frequently called method, but adding a member variable bloats
the size of this object, one of which lives on every WebContents. I don't think
performance overhead is really an issue here - I'd be surprised if users often
added to homescreen from the exact same tab multiple times.

2) some example of not caching include:

chrome/browser/android/contextualsearch/contextual_search_manager.cc
chrome/browser/task_manager/providers/child_process_task.cc
chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/chrome_render_thread_observer.cc

And app_banner_manager.cc too.

3) make it a local variable here and in AddToHomescreenManager. :)

[Matt Giuca, 2016/12/14 03:39:40]

Done.

+    web_contents()->GetMainFrame()->GetRemoteInterfaces()->GetInterface(
+        mojo::GetProxy(&installation_service_));
+    DCHECK(installation_service_);
+  }
+  installation_service_->OnInstall();
+}
+
 void AppBannerManager::SendBannerAccepted(int request_id) {
   if (request_id != gCurrentRequestID)
     return;