Implement AnimationEffectTimingReadOnly interface

Implement AnimationEffectTimingReadOnly interface

This patch implements AnimationEffectTimingReadOnly, an interface of the
Web Animations API that is currently missing
(http://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface).
The interface is only exposed behind the experimental-web-platform-features
flag.

BUG=624639
Committed: https://crrev.com/1eb6e3ef5f59e0423ec0a6ab3e35812122ca1399
Cr-Commit-Position: refs/heads/master@{#423064}

[suzyh_UTC10 (ex-contributor), 2016-09-29 02:59:36]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-09-30 04:32:10]

lgtm after non-nit is resolved.

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h
(right):

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/AnimationEffectTimingReadOnly.h:1: //
Copyright 2014 The Chromium Authors. All rights reserved.
Nit: 2016 here and other files.

[alancutter (OOO until 2018), 2016-09-30 04:32:46]

Oops, didn't click save.

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
(right):

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:351:
AnimationEffectTiming* timing = toKeyframeEffect(animation->effect())->timing();
Non-nit: Downcast timing instead of effect object.

[suzyh_UTC10 (ex-contributor), 2016-10-04 06:57:31]

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
(right):

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:351:
AnimationEffectTiming* timing = toKeyframeEffect(animation->effect())->timing();
On 2016/09/30 at 04:32:46, alancutter wrote:
> Non-nit: Downcast timing instead of effect object.

This will require defining the type casts for the AnimationEffectTiming*
hierarchy. I'm not sure if there's any downside to doing this. Are you happy for
me to add the extra boilerplate needed for this?

[alancutter (OOO until 2018), 2016-10-04 11:59:19]

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
(right):

https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:351:
AnimationEffectTiming* timing = toKeyframeEffect(animation->effect())->timing();
On 2016/10/04 at 06:57:31, suzyh wrote:
> On 2016/09/30 at 04:32:46, alancutter wrote:
> > Non-nit: Downcast timing instead of effect object.
> 
> This will require defining the type casts for the AnimationEffectTiming*
hierarchy. I'm not sure if there's any downside to doing this. Are you happy for
me to add the extra boilerplate needed for this?

Yes. I don't think this code should be assuming a KeyframeEffect, down casting
the timing object is the closest equivalent to what occurs in Javascript land.

[suzyh_UTC10 (ex-contributor), 2016-10-04 23:54:46]

On 2016/10/04 at 11:59:19, alancutter wrote:
>
https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
(right):
> 
>
https://codereview.chromium.org/2379863003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp:351:
AnimationEffectTiming* timing = toKeyframeEffect(animation->effect())->timing();
> On 2016/10/04 at 06:57:31, suzyh wrote:
> > On 2016/09/30 at 04:32:46, alancutter wrote:
> > > Non-nit: Downcast timing instead of effect object.
> > 
> > This will require defining the type casts for the AnimationEffectTiming*
hierarchy. I'm not sure if there's any downside to doing this. Are you happy for
me to add the extra boilerplate needed for this?
> 
> Yes. I don't think this code should be assuming a KeyframeEffect, down casting
the timing object is the closest equivalent to what occurs in Javascript land.

Done, PTAL

[alancutter (OOO until 2018), 2016-10-05 00:22:15]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-10-05 00:29:15]

suzyh@chromium.org changed reviewers:
+ dstockwell@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-10-05 00:29:25]

+dstockwell for core/

[dstockwell, 2016-10-05 00:36:13]

lgtm

[suzyh_UTC10 (ex-contributor), 2016-10-05 01:29:29]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2016-10-05 01:29:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:19:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 03:23:24]

Description was changed from

==========
Implement AnimationEffectTimingReadOnly interface

This patch implements AnimationEffectTimingReadOnly, an interface of the
Web Animations API that is currently missing
(http://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface).
The interface is only exposed behind the experimental-web-platform-features
flag.

BUG=624639
==========

to

==========
Implement AnimationEffectTimingReadOnly interface

This patch implements AnimationEffectTimingReadOnly, an interface of the
Web Animations API that is currently missing
(http://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface).
The interface is only exposed behind the experimental-web-platform-features
flag.

BUG=624639

Committed: https://crrev.com/1eb6e3ef5f59e0423ec0a6ab3e35812122ca1399
Cr-Commit-Position: refs/heads/master@{#423064}
==========

[commit-bot: I haz the power, 2016-10-05 03:23:25]

Patchset 2 (id:??) landed as
https://crrev.com/1eb6e3ef5f59e0423ec0a6ab3e35812122ca1399
Cr-Commit-Position: refs/heads/master@{#423064}