Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/core/animation/AnimationEffectTiming.h

Issue 2379863003: Implement AnimationEffectTimingReadOnly interface (Closed)
Patch Set: Response to review, update formatting of new files Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
diff --git a/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h b/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
index d20d07ac14c68bc2c5ba38f7dfdc56d97514b8e4..bb905bb09dcf59307dea5bc3222bc352a9ddeabe 100644
--- a/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
+++ b/third_party/WebKit/Source/core/animation/AnimationEffectTiming.h
@@ -5,9 +5,9 @@
#ifndef AnimationEffectTiming_h
#define AnimationEffectTiming_h
-#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
#include "core/animation/AnimationEffectReadOnly.h"
+#include "core/animation/AnimationEffectTimingReadOnly.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -15,22 +15,11 @@ namespace blink {
class ExceptionState;
class UnrestrictedDoubleOrString;
-class CORE_EXPORT AnimationEffectTiming
- : public GarbageCollected<AnimationEffectTiming>,
- public ScriptWrappable {
+class CORE_EXPORT AnimationEffectTiming : public AnimationEffectTimingReadOnly {
DEFINE_WRAPPERTYPEINFO();
public:
static AnimationEffectTiming* create(AnimationEffectReadOnly* parent);
- double delay();
- double endDelay();
- String fill();
- double iterationStart();
- double iterations();
- void duration(UnrestrictedDoubleOrString&);
- double playbackRate();
- String direction();
- String easing();
void setDelay(double);
void setEndDelay(double);
@@ -42,13 +31,20 @@ class CORE_EXPORT AnimationEffectTiming
void setDirection(String);
void setEasing(String, ExceptionState&);
- DECLARE_TRACE();
+ bool isAnimationEffectTiming() const override { return true; }
+
+ DECLARE_VIRTUAL_TRACE();
private:
- Member<AnimationEffectReadOnly> m_parent;
explicit AnimationEffectTiming(AnimationEffectReadOnly*);
};
+DEFINE_TYPE_CASTS(AnimationEffectTiming,
+ AnimationEffectTimingReadOnly,
+ timing,
+ timing->isAnimationEffectTiming(),
+ timing.isAnimationEffectTiming());
+
} // namespace blink
#endif

Powered by Google App Engine
This is Rietveld 408576698