Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)
Patch Set: Less crashing Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/public/renderer/render_frame_observer.h ('K') | « content/renderer/media/user_media_client_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 54972feabefcc319e1758e46937b7a1ce1d11736..729a76c259b73f30f08023a72672e89fcf1b7c68 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2944,10 +2944,8 @@ void RenderFrameImpl::frameFocused() {
void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) {
DCHECK_EQ(frame_, frame);
- // TODO(dcheng): Rename observer to FrameWillCommitProvisionalLoad.
- FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FrameWillClose());
- FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
- FrameWillClose(frame));
+ FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
+ WillCommitProvisionalLoad());
}
void RenderFrameImpl::didChangeName(const blink::WebString& name,
« content/public/renderer/render_frame_observer.h ('K') | « content/renderer/media/user_media_client_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698