Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)
Patch Set: Less crashing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 2926 matching lines...) Expand 10 before | Expand all | Expand 10 after
2937 // Object is invalid after this point. 2937 // Object is invalid after this point.
2938 } 2938 }
2939 2939
2940 void RenderFrameImpl::frameFocused() { 2940 void RenderFrameImpl::frameFocused() {
2941 Send(new FrameHostMsg_FrameFocused(routing_id_)); 2941 Send(new FrameHostMsg_FrameFocused(routing_id_));
2942 } 2942 }
2943 2943
2944 void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) { 2944 void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) {
2945 DCHECK_EQ(frame_, frame); 2945 DCHECK_EQ(frame_, frame);
2946 2946
2947 // TODO(dcheng): Rename observer to FrameWillCommitProvisionalLoad. 2947 FOR_EACH_OBSERVER(RenderFrameObserver, observers_,
2948 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FrameWillClose()); 2948 WillCommitProvisionalLoad());
2949 FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
2950 FrameWillClose(frame));
2951 } 2949 }
2952 2950
2953 void RenderFrameImpl::didChangeName(const blink::WebString& name, 2951 void RenderFrameImpl::didChangeName(const blink::WebString& name,
2954 const blink::WebString& unique_name) { 2952 const blink::WebString& unique_name) {
2955 // TODO(alexmos): According to https://crbug.com/169110, sending window.name 2953 // TODO(alexmos): According to https://crbug.com/169110, sending window.name
2956 // updates may have performance implications for benchmarks like SunSpider. 2954 // updates may have performance implications for benchmarks like SunSpider.
2957 // For now, send these updates only for --site-per-process, which needs to 2955 // For now, send these updates only for --site-per-process, which needs to
2958 // replicate frame names to frame proxies, and when 2956 // replicate frame names to frame proxies, and when
2959 // |report_frame_name_changes| is set (used by <webview>). If needed, this 2957 // |report_frame_name_changes| is set (used by <webview>). If needed, this
2960 // can be optimized further by only sending the update if there are any 2958 // can be optimized further by only sending the update if there are any
(...skipping 3481 matching lines...) Expand 10 before | Expand all | Expand 10 after
6442 // event target. Potentially a Pepper plugin will receive the event. 6440 // event target. Potentially a Pepper plugin will receive the event.
6443 // In order to tell whether a plugin gets the last mouse event and which it 6441 // In order to tell whether a plugin gets the last mouse event and which it
6444 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6442 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6445 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6443 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6446 // |pepper_last_mouse_event_target_|. 6444 // |pepper_last_mouse_event_target_|.
6447 pepper_last_mouse_event_target_ = nullptr; 6445 pepper_last_mouse_event_target_ = nullptr;
6448 #endif 6446 #endif
6449 } 6447 }
6450 6448
6451 } // namespace content 6449 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698