Rename RFO::FrameWillClose() to reflect its actual purpose.

content/public/renderer/render_frame_observer.h

Index: content/public/renderer/render_frame_observer.h
diff --git a/content/public/renderer/render_frame_observer.h b/content/public/renderer/render_frame_observer.h
index 8357949e2078896ae23b21eed1cf3d3e4eeab210..ea667d4a8125715a4cf577484ad235720e0848ad 100644
--- a/content/public/renderer/render_frame_observer.h
+++ b/content/public/renderer/render_frame_observer.h
@@ -20,7 +20,7 @@
 
 namespace blink {
 class WebFormElement;
-class WebFrame;
+class WebLocalFrame;
 class WebNode;
 class WebString;
 struct WebURLError;
@@ -58,6 +58,9 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
   // These match the Blink API notifications
   virtual void DidCreateNewDocument() {}
   virtual void DidCreateDocumentElement() {}
+  // Called when a provisional load is about to commit in a frame. This is
+  // dispatched just before the Javascript unload event.
+  virtual void WillCommitProvisionalLoad() {}

[dcheng, 2016/09/30 06:20:42]

Looking at how this is used, I think these could all just be folded into
DidCommitProvisionalLoad. I'd like to try that in a followup CL, if it makes
sense to everyone.

   virtual void DidCommitProvisionalLoad(bool is_new_navigation,
                                         bool is_same_page_navigation) {}
   virtual void DidStartProvisionalLoad() {}
@@ -78,17 +81,11 @@ class CONTENT_EXPORT RenderFrameObserver : public IPC::Listener,
       const blink::WebVector<blink::WebString>& newly_matching_selectors,
       const blink::WebVector<blink::WebString>& stopped_matching_selectors) {}
 
-  // Called before FrameWillClose, when this frame has been detached from the
-  // view, but has not been closed yet. This *will* be called when parent frames
-  // are closing. Since the frame is already detached from the DOM at this time
-  // it should not be inspected.
+  // Called when this frame has been detached from the view. This *will* be
+  // called for child frames when a parent frame is detached. Since the frame is
+  // already detached from the DOM at this time, it should not be inspected.
   virtual void FrameDetached() {}
 
-  // Called when the frame will soon be closed. This is the last opportunity to
-  // send messages to the host (e.g., for clean-up, shutdown, etc.). This is
-  // *not* called on child frames when parent frames are being closed.
-  virtual void FrameWillClose() {}
-
   // Called when we receive a console message from Blink for which we requested
   // extra details (like the stack trace). |message| is the error message,
   // |source| is the Blink-reported source of the error (either external or