components/autofill/content/renderer/password_autofill_agent.h - Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)

Patch Set: Less crashing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index aec6edf04c4f719ba27eded249e4a7a283072aaa..188742987934fab19962340d0796a2f252925b3b 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -184,8 +184,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver,

void DidFinishDocumentLoad() override;

void DidFinishLoad() override;

void FrameDetached() override;

- void FrameWillClose() override;

void DidStartProvisionalLoad() override;

+ void WillCommitProvisionalLoad() override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;

void WillSendSubmitEvent(const blink::WebFormElement& form) override;