components/autofill/content/renderer/password_autofill_agent.cc - Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2379293002: Rename RFO::FrameWillClose() to reflect its actual purpose. (Closed)

Patch Set: Less crashing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/password_autofill_agent.cc

diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc

index c4038ecf816eec46d53cf4041fbd0228c4e8d1a5..0397c3b7ffd4a80fb39fcdb8b8133cfcfd24b1ff 100644

--- a/components/autofill/content/renderer/password_autofill_agent.cc

+++ b/components/autofill/content/renderer/password_autofill_agent.cc

@@ -1059,7 +1059,7 @@ void PasswordAutofillAgent::DidFinishLoad() {

SendPasswordForms(true);

}

-void PasswordAutofillAgent::FrameWillClose() {

+void PasswordAutofillAgent::WillCommitProvisionalLoad() {

FrameClosing();

}