Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2379023002: [SyzyAsan] Fix overflow error in ShadowWalker for 4GB 32-bit processes. (Closed)

Created:
4 years, 2 months ago by chrisha
Modified:
4 years, 2 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

[SyzyAsan] Fix overflow error in ShadowWalker for 4GB 32-bit processes. BUG=https://github.com/google/syzygy/issues/51 Committed: https://github.com/google/syzygy/commit/c86c6caeaef9014e707d12215c3b55fecb874043

Patch Set 1 #

Patch Set 2 : Fix comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -97 lines) Patch
M syzygy/agent/asan/heap_checker.h View 1 chunk +4 lines, -3 lines 0 comments Download
M syzygy/agent/asan/heap_checker.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M syzygy/agent/asan/runtime.cc View 1 chunk +2 lines, -1 line 0 comments Download
M syzygy/agent/asan/shadow.h View 3 chunks +13 lines, -13 lines 0 comments Download
M syzygy/agent/asan/shadow.cc View 2 chunks +65 lines, -74 lines 1 comment Download
M syzygy/agent/asan/shadow_unittest.cc View 2 chunks +22 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
chrisha
PTAL? https://codereview.chromium.org/2379023002/diff/20001/syzygy/agent/asan/shadow.cc File syzygy/agent/asan/shadow.cc (left): https://codereview.chromium.org/2379023002/diff/20001/syzygy/agent/asan/shadow.cc#oldcode1158 syzygy/agent/asan/shadow.cc:1158: sizeof(memory_info)); Doing this at every step is quite ...
4 years, 2 months ago (2016-09-29 14:12:10 UTC) #1
Sébastien Marchand
lgtm
4 years, 2 months ago (2016-09-29 14:53:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2379023002/20001
4 years, 2 months ago (2016-09-29 15:07:03 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:07:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/google/syzygy/commit/c86c6caeaef9014e707d12215c3b55fecb874043

Powered by Google App Engine
This is Rietveld 408576698