Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: syzygy/agent/asan/heap_checker.h

Issue 2379023002: [SyzyAsan] Fix overflow error in ShadowWalker for 4GB 32-bit processes. (Closed)
Patch Set: Fix comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | syzygy/agent/asan/heap_checker.cc » ('j') | syzygy/agent/asan/shadow.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/agent/asan/heap_checker.h
diff --git a/syzygy/agent/asan/heap_checker.h b/syzygy/agent/asan/heap_checker.h
index 980208bb9386ad6a24267106ba5295b479c66646..49bb7e67ca614b2760a73f5788e9db8aa8efa48c 100644
--- a/syzygy/agent/asan/heap_checker.h
+++ b/syzygy/agent/asan/heap_checker.h
@@ -53,12 +53,13 @@ class HeapChecker {
private:
// Get the information about the corrupt ranges in a heap slab.
- // @param lower_bound The lower bound for this slab.
- // @param length The length of this slab.
+ // @param lower_bound The lower bound for this slab (inclusive).
+ // @param upper_bound The upper bound for this slab (exclusive). An
+ // overflowed value of 0 indicates the end of all memory.
// @param corrupt_ranges Will receive the information about the corrupt ranges
// in this slab.
void GetCorruptRangesInSlab(const uint8_t* lower_bound,
- size_t length,
+ const uint8_t* upper_bound,
CorruptRangesVector* corrupt_ranges);
// The shadow memory that will be analyzed.
« no previous file with comments | « no previous file | syzygy/agent/asan/heap_checker.cc » ('j') | syzygy/agent/asan/shadow.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698