Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2383793003: [SyzyAsan] More careful handling when freeing corrupt blocks. (Closed)

Created:
4 years, 2 months ago by chrisha
Modified:
4 years, 2 months ago
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

[SyzyAsan] More careful handling when freeing corrupt blocks. This makes the code around the RegistryFilter integration much more robust, and fixes a crash that was occurring on ClusterFuzz. BUG=https://github.com/google/syzygy/issues/51 Committed: https://github.com/google/syzygy/commit/2662b3a8a2610d747dfd5fcbb348f8c3ef2f2706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -56 lines) Patch
M syzygy/agent/asan/heap_managers/block_heap_manager.h View 2 chunks +6 lines, -1 line 0 comments Download
M syzygy/agent/asan/heap_managers/block_heap_manager.cc View 4 chunks +89 lines, -7 lines 0 comments Download
M syzygy/agent/asan/heap_managers/block_heap_manager_unittest.cc View 3 chunks +128 lines, -48 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
chrisha
PTAL?
4 years, 2 months ago (2016-09-30 17:17:45 UTC) #2
chrisha
Ping? Ideally this would be in the binaries we roll to ClusterFuzz, as this is ...
4 years, 2 months ago (2016-10-03 15:27:39 UTC) #7
Sébastien Marchand
Ha sorry, I reviewed it but forgot to approve! LGTM
4 years, 2 months ago (2016-10-03 15:30:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383793003/1
4 years, 2 months ago (2016-10-03 17:21:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:58:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/google/syzygy/commit/2662b3a8a2610d747dfd5fcbb348f8c3ef2f2706

Powered by Google App Engine
This is Rietveld 408576698