Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2378863002: Milo: Outbound LogDog calls use user delegation. (Closed)

Created:
4 years, 2 months ago by dnj
Modified:
4 years, 2 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Outbound LogDog calls use user delegation. BUG=chromium:651177 TEST=None Committed: https://github.com/luci/luci-go/commit/8520cfdf2e9c4e7459305f4da3f70c0fb916ceac

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M milo/appengine/logdog/http.go View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
PTAL!
4 years, 2 months ago (2016-09-28 19:35:30 UTC) #2
Vadim Sh.
lgtm https://codereview.chromium.org/2378863002/diff/1/milo/appengine/logdog/http.go File milo/appengine/logdog/http.go (right): https://codereview.chromium.org/2378863002/diff/1/milo/appengine/logdog/http.go#newcode43 milo/appengine/logdog/http.go:43: // TODO(vadimsh): Use auth.AsUser. remove the TODO
4 years, 2 months ago (2016-09-28 19:42:20 UTC) #3
dnj
https://codereview.chromium.org/2378863002/diff/1/milo/appengine/logdog/http.go File milo/appengine/logdog/http.go (right): https://codereview.chromium.org/2378863002/diff/1/milo/appengine/logdog/http.go#newcode43 milo/appengine/logdog/http.go:43: // TODO(vadimsh): Use auth.AsUser. On 2016/09/28 19:42:20, Vadim Sh. ...
4 years, 2 months ago (2016-09-28 20:12:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378863002/20001
4 years, 2 months ago (2016-09-28 20:13:03 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:26:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/8520cfdf2e9c4e7459305f4da3f70c0fb916ceac

Powered by Google App Engine
This is Rietveld 408576698