Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: milo/appengine/logdog/http.go

Issue 2378863002: Milo: Outbound LogDog calls use user delegation. (Closed)
Patch Set: Remove TODO Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/logdog/http.go
diff --git a/milo/appengine/logdog/http.go b/milo/appengine/logdog/http.go
index 7298487649a6087b76d060bb4c460ddb03fc0620..244bfb32fa0320fb096dafaedcdc9ab79ca56bab 100644
--- a/milo/appengine/logdog/http.go
+++ b/milo/appengine/logdog/http.go
@@ -40,8 +40,7 @@ func (s *AnnotationStream) GetTemplateName(t settings.Theme) string {
// Render implements settings.ThemedHandler.
func (s *AnnotationStream) Render(c context.Context, req *http.Request, p httprouter.Params) (*templates.Args, error) {
// Initialize the LogDog client authentication.
- // TODO(vadimsh): Use auth.AsUser.
- t, err := auth.GetRPCTransport(c, auth.AsSelf)
+ t, err := auth.GetRPCTransport(c, auth.AsUser)
if err != nil {
log.WithError(err).Errorf(c, "Failed to get transport for LogDog server.")
return nil, &miloerror.Error{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698