Milo: Outbound LogDog calls use user delegation.

milo/appengine/logdog/http.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package logdog
 
 import (
         "net/http"
         "strings"
 
@@ skipping 22 matching lines @@
 }
 
 // GetTemplateName implements settings.ThemedHandler.
 func (s *AnnotationStream) GetTemplateName(t settings.Theme) string {
         return "build.html"
 }
 
 // Render implements settings.ThemedHandler.
 func (s *AnnotationStream) Render(c context.Context, req *http.Request, p httprouter.Params) (*templates.Args, error) {
         // Initialize the LogDog client authentication.
         // TODO(vadimsh): Use auth.AsUser.

[Vadim Sh., 2016/09/28 19:42:20]

remove the TODO

[dnj, 2016/09/28 20:12:52]

lol didn't even see that.

-        t, err := auth.GetRPCTransport(c, auth.AsSelf)
+        t, err := auth.GetRPCTransport(c, auth.AsUser)
         if err != nil {
                 log.WithError(err).Errorf(c, "Failed to get transport for LogDog server.")
                 return nil, &miloerror.Error{
                         Code: http.StatusInternalServerError,
                 }
         }
 
         as := annotationStreamRequest{
                 AnnotationStream: s,
 
@@ skipping 16 matching lines @@
         // Load the Milo annotation protobuf from the annotation stream.
         if err := as.load(c); err != nil {
                 return nil, err
         }
 
         // Convert the Milo Annotation protobuf to Milo objects.
         return &templates.Args{
                 "Build": as.toMiloBuild(c),
         }, nil
 }