Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2378473002: Stop passing browser command line args for no_gpu_process on Android. (Closed)

Created:
4 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Khushal, no sievers, Julien Isorce Samsung
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop passing browser command line args for no_gpu_process on Android. This test needs to be skipped completely on Android, and specifying --gpu-testing-vendor-id and --gpu-testing-device-id is causing the browser to fail to start in some configurations. BUG=643282 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/fedd84744b63c072dd81871332c2d73619b4890d Cr-Commit-Position: refs/heads/master@{#421371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/test/gpu/page_sets/gpu_process_tests.py View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ken Russell (switch to Gerrit)
FYI. Tested locally. CQ'ing TBR'd.
4 years, 2 months ago (2016-09-27 21:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378473002/1
4 years, 2 months ago (2016-09-27 21:15:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:51:21 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:53:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fedd84744b63c072dd81871332c2d73619b4890d
Cr-Commit-Position: refs/heads/master@{#421371}

Powered by Google App Engine
This is Rietveld 408576698