Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: content/test/gpu/page_sets/gpu_process_tests.py

Issue 2378473002: Stop passing browser command line args for no_gpu_process on Android. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import sys 4 import sys
5 from telemetry.story import story_set as story_set_module 5 from telemetry.story import story_set as story_set_module
6 from telemetry.page import page_test 6 from telemetry.page import page_test
7 7
8 from gpu_tests import gpu_test_base 8 from gpu_tests import gpu_test_base
9 9
10 class GpuProcessSharedPageState(gpu_test_base.GpuSharedPageState): 10 class GpuProcessSharedPageState(gpu_test_base.GpuSharedPageState):
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 raise page_test.Failure('Must have a non-empty gl_renderer string') 210 raise page_test.Failure('Must have a non-empty gl_renderer string')
211 211
212 212
213 class NoGpuProcessSharedPageState(GpuProcessSharedPageState): 213 class NoGpuProcessSharedPageState(GpuProcessSharedPageState):
214 def __init__(self, test, finder_options, story_set): 214 def __init__(self, test, finder_options, story_set):
215 super(NoGpuProcessSharedPageState, self).__init__( 215 super(NoGpuProcessSharedPageState, self).__init__(
216 test, finder_options, story_set) 216 test, finder_options, story_set)
217 options = finder_options.browser_options 217 options = finder_options.browser_options
218 218
219 if options.browser_type.startswith('android'): 219 if options.browser_type.startswith('android'):
220 # Hit id 8 from kSoftwareRenderingListJson, which applies to any platform. 220 # Android doesn't support starting up the browser without any
221 options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10de') 221 # GPU process. This test is skipped on Android in
222 options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x0324') 222 # gpu_process_expectations.py, but we must at least be able to
223 # bring up the browser in order to detect that the test
224 # shouldn't run. Faking a vendor and device ID can get the
225 # browser into a state where it won't launch.
226 pass
223 elif sys.platform in ('cygwin', 'win32'): 227 elif sys.platform in ('cygwin', 'win32'):
224 # Hit id 34 from kSoftwareRenderingListJson. 228 # Hit id 34 from kSoftwareRenderingListJson.
225 options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x5333') 229 options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x5333')
226 options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x8811') 230 options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x8811')
227 elif sys.platform.startswith('linux'): 231 elif sys.platform.startswith('linux'):
228 # Hit id 50 from kSoftwareRenderingListJson. 232 # Hit id 50 from kSoftwareRenderingListJson.
229 options.AppendExtraBrowserArgs('--gpu-no-complete-info-collection') 233 options.AppendExtraBrowserArgs('--gpu-no-complete-info-collection')
230 options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10de') 234 options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10de')
231 options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x0de1') 235 options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x0de1')
232 options.AppendExtraBrowserArgs('--gpu-testing-gl-vendor=VMware') 236 options.AppendExtraBrowserArgs('--gpu-testing-gl-vendor=VMware')
(...skipping 526 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 763
760 # There is currently no entry in kSoftwareRenderingListJson that enables 764 # There is currently no entry in kSoftwareRenderingListJson that enables
761 # a software GL driver on Android. 765 # a software GL driver on Android.
762 self.AddStory(SoftwareGpuProcessPage(self, expectations)) 766 self.AddStory(SoftwareGpuProcessPage(self, expectations))
763 767
764 @property 768 @property
765 def allow_mixed_story_states(self): 769 def allow_mixed_story_states(self):
766 # Return True here in order to be able to run pages with different browser 770 # Return True here in order to be able to run pages with different browser
767 # command line arguments. 771 # command line arguments.
768 return True 772 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698